xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/omap: Don't call .check_timings() operation recursively

Browse Source 
The .check_timings() operation is called recursively from the display
device back to the output device. Most components just forward the
operation to the previous component in the chain, resulting in lots of
duplicated pass-through functions. To avoid that, iterate over the
components manually.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
This commit is contained in:
Laurent Pinchart
2018-06-06 00:55:48 +03:00
committed by Tomi Valkeinen
parent b4935e3a3c
commit 28120302c2
15 changed files with 32 additions and 139 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/gpu/drm/omapdrm/omap_encoder.c
View File

@@ -98,17 +98,23 @@ static int omap_encoder_update(struct drm_encoder *encoder,
{
struct drm_device *dev = encoder->dev;
struct omap_encoder *omap_encoder = to_omap_encoder(encoder);
struct omap_dss_device *dssdev = omap_encoder->display;
struct omap_dss_device *display = omap_encoder->display;
struct omap_dss_device *dssdev;
int ret;
ret = dssdev->ops->check_timings(dssdev, vm);
if (ret) {
dev_err(dev->dev, "invalid timings: %d\n", ret);
return ret;
for (dssdev = omap_encoder->output; dssdev; dssdev = dssdev->next) {
if (!dssdev->ops->check_timings)
continue;
ret = dssdev->ops->check_timings(dssdev, vm);
if (ret) {
dev_err(dev->dev, "invalid timings: %d\n", ret);
return ret;
}
}
if (dssdev->ops->set_timings)
dssdev->ops->set_timings(dssdev, vm);
if (display->ops->set_timings)
display->ops->set_timings(display, vm);
return 0;
}