bpf: Folding omem_charge() into sk_storage_charge()
[ Upstream commit 9e838b02b0bb795793f12049307a354e28b5749c ] sk_storage_charge() is the only user of omem_charge(). This patch simplifies it by folding omem_charge() into sk_storage_charge(). Signed-off-by: Martin KaFai Lau <kafai@fb.com> Signed-off-by: Alexei Starovoitov <ast@kernel.org> Acked-by: Song Liu <songliubraving@fb.com> Acked-by: KP Singh <kpsingh@google.com> Link: https://lore.kernel.org/bpf/20201112211301.2586255-1-kafai@fb.com Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
4d4e39245d
commit
27e8ade792
@@ -15,18 +15,6 @@
|
|||||||
|
|
||||||
DEFINE_BPF_STORAGE_CACHE(sk_cache);
|
DEFINE_BPF_STORAGE_CACHE(sk_cache);
|
||||||
|
|
||||||
static int omem_charge(struct sock *sk, unsigned int size)
|
|
||||||
{
|
|
||||||
/* same check as in sock_kmalloc() */
|
|
||||||
if (size <= sysctl_optmem_max &&
|
|
||||||
atomic_read(&sk->sk_omem_alloc) + size < sysctl_optmem_max) {
|
|
||||||
atomic_add(size, &sk->sk_omem_alloc);
|
|
||||||
return 0;
|
|
||||||
}
|
|
||||||
|
|
||||||
return -ENOMEM;
|
|
||||||
}
|
|
||||||
|
|
||||||
static struct bpf_local_storage_data *
|
static struct bpf_local_storage_data *
|
||||||
sk_storage_lookup(struct sock *sk, struct bpf_map *map, bool cacheit_lockit)
|
sk_storage_lookup(struct sock *sk, struct bpf_map *map, bool cacheit_lockit)
|
||||||
{
|
{
|
||||||
@@ -316,7 +304,16 @@ BPF_CALL_2(bpf_sk_storage_delete, struct bpf_map *, map, struct sock *, sk)
|
|||||||
static int sk_storage_charge(struct bpf_local_storage_map *smap,
|
static int sk_storage_charge(struct bpf_local_storage_map *smap,
|
||||||
void *owner, u32 size)
|
void *owner, u32 size)
|
||||||
{
|
{
|
||||||
return omem_charge(owner, size);
|
struct sock *sk = (struct sock *)owner;
|
||||||
|
|
||||||
|
/* same check as in sock_kmalloc() */
|
||||||
|
if (size <= sysctl_optmem_max &&
|
||||||
|
atomic_read(&sk->sk_omem_alloc) + size < sysctl_optmem_max) {
|
||||||
|
atomic_add(size, &sk->sk_omem_alloc);
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
return -ENOMEM;
|
||||||
}
|
}
|
||||||
|
|
||||||
static void sk_storage_uncharge(struct bpf_local_storage_map *smap,
|
static void sk_storage_uncharge(struct bpf_local_storage_map *smap,
|
||||||
|
Reference in New Issue
Block a user