xfs: reuse _xfs_buf_read for re-reading the superblock
Instead of poking deeply into buffer cache internals when re-reading the superblock during log recovery just generalize _xfs_buf_read and use it there. Note that we don't have to explicitly set up the ops as they must be set from the initial read. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
This commit is contained in:

committed by
Darrick J. Wong

parent
b3f8e08ca8
commit
26e328759b
@@ -52,6 +52,15 @@ static kmem_zone_t *xfs_buf_zone;
|
||||
* b_lock (trylock due to inversion)
|
||||
*/
|
||||
|
||||
static int __xfs_buf_submit(struct xfs_buf *bp, bool wait);
|
||||
|
||||
static inline int
|
||||
xfs_buf_submit(
|
||||
struct xfs_buf *bp)
|
||||
{
|
||||
return __xfs_buf_submit(bp, !(bp->b_flags & XBF_ASYNC));
|
||||
}
|
||||
|
||||
static inline int
|
||||
xfs_buf_is_vmapped(
|
||||
struct xfs_buf *bp)
|
||||
@@ -751,7 +760,7 @@ found:
|
||||
return 0;
|
||||
}
|
||||
|
||||
STATIC int
|
||||
int
|
||||
_xfs_buf_read(
|
||||
xfs_buf_t *bp,
|
||||
xfs_buf_flags_t flags)
|
||||
@@ -759,7 +768,7 @@ _xfs_buf_read(
|
||||
ASSERT(!(flags & XBF_WRITE));
|
||||
ASSERT(bp->b_maps[0].bm_bn != XFS_BUF_DADDR_NULL);
|
||||
|
||||
bp->b_flags &= ~(XBF_WRITE | XBF_ASYNC | XBF_READ_AHEAD);
|
||||
bp->b_flags &= ~(XBF_WRITE | XBF_ASYNC | XBF_READ_AHEAD | XBF_DONE);
|
||||
bp->b_flags |= flags & (XBF_READ | XBF_ASYNC | XBF_READ_AHEAD);
|
||||
|
||||
return xfs_buf_submit(bp);
|
||||
@@ -1639,7 +1648,7 @@ xfs_buf_iowait(
|
||||
* safe to reference the buffer after a call to this function unless the caller
|
||||
* holds an additional reference itself.
|
||||
*/
|
||||
int
|
||||
static int
|
||||
__xfs_buf_submit(
|
||||
struct xfs_buf *bp,
|
||||
bool wait)
|
||||
|
Reference in New Issue
Block a user