xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mtd: rawnand: mxc: remove __init qualifier from mxcnd_probe_dt

Browse Source 
Using the sysfs unbind, bind nodes, mxcnd_probe and mxcnd_probe_dt can
potentially be called at any time. After the __init functions are cleaned,
mxcnd_probe_dt is no longer available. Calling it anyway causes a crash.

mxcnd_probe used to be marked as __init, this was removed years ago.
Remove the __init qualifier from from mxcnd_probe_dt as well.

Fixes: 06f2551069 ("mtd: remove use of __devinit")
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
This commit is contained in:
Martin Kaiser
2018-06-27 22:47:44 +02:00
committed by Miquel Raynal
parent 3dfa025f89
commit 24f0ae995d
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/mtd/nand/raw/mxc_nand.c
View File

@@ -1686,7 +1686,7 @@ static const struct of_device_id mxcnd_dt_ids[] = {
}; };
MODULE_DEVICE_TABLE(of, mxcnd_dt_ids); MODULE_DEVICE_TABLE(of, mxcnd_dt_ids);
static int __init mxcnd_probe_dt(struct mxc_nand_host *host) static int mxcnd_probe_dt(struct mxc_nand_host *host)
{ {
struct device_node *np = host->dev->of_node; struct device_node *np = host->dev->of_node;
const struct of_device_id *of_id = const struct of_device_id *of_id =
@@ -1700,7 +1700,7 @@ static int __init mxcnd_probe_dt(struct mxc_nand_host *host)
return 0; return 0;
} }
#else #else
static int __init mxcnd_probe_dt(struct mxc_nand_host *host) static int mxcnd_probe_dt(struct mxc_nand_host *host)
{ {
return 1; return 1;
} }