proc: Make inline name size calculation automatic
Make calculation of the size of the inline name in struct proc_dir_entry automatic, rather than having to manually encode the numbers and failing to allow for lockdep. Require a minimum inline name size of 33+1 to allow for names that look like two hex numbers with a dash between. Reported-by: Al Viro <viro@ZenIV.linux.org.uk> Signed-off-by: David Howells <dhowells@redhat.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
@@ -62,14 +62,20 @@ struct proc_dir_entry {
|
||||
char *name;
|
||||
umode_t mode;
|
||||
u8 namelen;
|
||||
#ifdef CONFIG_64BIT
|
||||
#define SIZEOF_PDE_INLINE_NAME (192-155)
|
||||
#else
|
||||
#define SIZEOF_PDE_INLINE_NAME (128-95)
|
||||
#endif
|
||||
char inline_name[SIZEOF_PDE_INLINE_NAME];
|
||||
char inline_name[];
|
||||
} __randomize_layout;
|
||||
|
||||
#define OFFSETOF_PDE_NAME offsetof(struct proc_dir_entry, inline_name)
|
||||
#define SIZEOF_PDE_SLOT \
|
||||
(OFFSETOF_PDE_NAME + 34 <= 64 ? 64 : \
|
||||
OFFSETOF_PDE_NAME + 34 <= 128 ? 128 : \
|
||||
OFFSETOF_PDE_NAME + 34 <= 192 ? 192 : \
|
||||
OFFSETOF_PDE_NAME + 34 <= 256 ? 256 : \
|
||||
OFFSETOF_PDE_NAME + 34 <= 512 ? 512 : \
|
||||
0)
|
||||
|
||||
#define SIZEOF_PDE_INLINE_NAME (SIZEOF_PDE_SLOT - OFFSETOF_PDE_NAME)
|
||||
|
||||
extern struct kmem_cache *proc_dir_entry_cache;
|
||||
void pde_free(struct proc_dir_entry *pde);
|
||||
|
||||
|
Reference in New Issue
Block a user