saner FASYNC handling on file close
As it is, all instances of ->release() for files that have ->fasync() need to remember to evict file from fasync lists; forgetting that creates a hole and we actually have a bunch that *does* forget. So let's keep our lives simple - let __fput() check FASYNC in file->f_flags and call ->fasync() there if it's been set. And lose that crap in ->release() instances - leaving it there is still valid, but we don't have to bother anymore. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
@@ -1828,9 +1828,6 @@ static int dv1394_release(struct inode *inode, struct file *file)
|
||||
/* OK to free the DMA buffer, no more mappings can exist */
|
||||
do_dv1394_shutdown(video, 1);
|
||||
|
||||
/* clean up async I/O users */
|
||||
dv1394_fasync(-1, file, 0);
|
||||
|
||||
/* give someone else a turn */
|
||||
clear_bit(0, &video->open);
|
||||
|
||||
|
Reference in New Issue
Block a user