Merge branch 'for-linus-4.3' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs
Pull btrfs updates from Chris Mason: "This has Jeff Mahoney's long standing trim patch that fixes corners where trims were missing. Omar has some raid5/6 fixes, especially for using scrub and device replace when devices are missing. Zhao Lie continues cleaning and fixing things, this series fixes some really hard to hit corners in xfstests. I had to pull it last merge window due to some deadlocks, but those are now resolved. I added support for Tejun's new blkio controllers. It seems to work well for single devices, we'll expand to multi-device as well" * 'for-linus-4.3' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs: (47 commits) btrfs: fix compile when block cgroups are not enabled Btrfs: fix file read corruption after extent cloning and fsync Btrfs: check if previous transaction aborted to avoid fs corruption btrfs: use __GFP_NOFAIL in alloc_btrfs_bio btrfs: Prevent from early transaction abort btrfs: Remove unused arguments in tree-log.c btrfs: Remove useless condition in start_log_trans() Btrfs: add support for blkio controllers Btrfs: remove unused mutex from struct 'btrfs_fs_info' Btrfs: fix parity scrub of RAID 5/6 with missing device Btrfs: fix device replace of a missing RAID 5/6 device Btrfs: add RAID 5/6 BTRFS_RBIO_REBUILD_MISSING operation Btrfs: count devices correctly in readahead during RAID 5/6 replace Btrfs: remove misleading handling of missing device scrub btrfs: fix clone / extent-same deadlocks Btrfs: fix defrag to merge tail file extent Btrfs: fix warning in backref walking btrfs: Add WARN_ON() for double lock in btrfs_tree_lock() btrfs: Remove root argument in extent_data_ref_count() btrfs: Fix wrong comment of btrfs_alloc_tree_block() ...
This commit is contained in:
@@ -3658,6 +3658,35 @@ cache_index:
|
||||
set_bit(BTRFS_INODE_NEEDS_FULL_SYNC,
|
||||
&BTRFS_I(inode)->runtime_flags);
|
||||
|
||||
/*
|
||||
* We don't persist the id of the transaction where an unlink operation
|
||||
* against the inode was last made. So here we assume the inode might
|
||||
* have been evicted, and therefore the exact value of last_unlink_trans
|
||||
* lost, and set it to last_trans to avoid metadata inconsistencies
|
||||
* between the inode and its parent if the inode is fsync'ed and the log
|
||||
* replayed. For example, in the scenario:
|
||||
*
|
||||
* touch mydir/foo
|
||||
* ln mydir/foo mydir/bar
|
||||
* sync
|
||||
* unlink mydir/bar
|
||||
* echo 2 > /proc/sys/vm/drop_caches # evicts inode
|
||||
* xfs_io -c fsync mydir/foo
|
||||
* <power failure>
|
||||
* mount fs, triggers fsync log replay
|
||||
*
|
||||
* We must make sure that when we fsync our inode foo we also log its
|
||||
* parent inode, otherwise after log replay the parent still has the
|
||||
* dentry with the "bar" name but our inode foo has a link count of 1
|
||||
* and doesn't have an inode ref with the name "bar" anymore.
|
||||
*
|
||||
* Setting last_unlink_trans to last_trans is a pessimistic approach,
|
||||
* but it guarantees correctness at the expense of ocassional full
|
||||
* transaction commits on fsync if our inode is a directory, or if our
|
||||
* inode is not a directory, logging its parent unnecessarily.
|
||||
*/
|
||||
BTRFS_I(inode)->last_unlink_trans = BTRFS_I(inode)->last_trans;
|
||||
|
||||
path->slots[0]++;
|
||||
if (inode->i_nlink != 1 ||
|
||||
path->slots[0] >= btrfs_header_nritems(leaf))
|
||||
@@ -7958,7 +7987,11 @@ out:
|
||||
static struct bio *btrfs_dio_bio_alloc(struct block_device *bdev,
|
||||
u64 first_sector, gfp_t gfp_flags)
|
||||
{
|
||||
return btrfs_bio_alloc(bdev, first_sector, BIO_MAX_PAGES, gfp_flags);
|
||||
struct bio *bio;
|
||||
bio = btrfs_bio_alloc(bdev, first_sector, BIO_MAX_PAGES, gfp_flags);
|
||||
if (bio)
|
||||
bio_associate_current(bio);
|
||||
return bio;
|
||||
}
|
||||
|
||||
static inline int btrfs_lookup_and_bind_dio_csum(struct btrfs_root *root,
|
||||
|
Reference in New Issue
Block a user