drm: Rename drm_mode_object_get()
Subsequent patches will introduce reference counting APIs that are more consistent with similar APIs throughout the Linux kernel. These APIs use the _get() and _put() suffixes and will collide with this existing function. Rename the function to drm_mode_object_add() which is a slightly more accurate description of what it does. Also the kerneldoc for this function gives an indication that it's badly named because it doesn't actually acquire a reference to anything. Reviewed-by: Sean Paul <seanpaul@chromium.org> Acked-by: Christian König <christian.koenig@amd.com> Signed-off-by: Thierry Reding <treding@nvidia.com> Link: http://patchwork.freedesktop.org/patch/msgid/20170228144643.5668-2-thierry.reding@gmail.com
This commit is contained in:
@@ -91,7 +91,7 @@ struct drm_property *drm_property_create(struct drm_device *dev, int flags,
|
||||
goto fail;
|
||||
}
|
||||
|
||||
ret = drm_mode_object_get(dev, &property->base, DRM_MODE_OBJECT_PROPERTY);
|
||||
ret = drm_mode_object_add(dev, &property->base, DRM_MODE_OBJECT_PROPERTY);
|
||||
if (ret)
|
||||
goto fail;
|
||||
|
||||
@@ -570,8 +570,8 @@ drm_property_create_blob(struct drm_device *dev, size_t length,
|
||||
if (data)
|
||||
memcpy(blob->data, data, length);
|
||||
|
||||
ret = drm_mode_object_get_reg(dev, &blob->base, DRM_MODE_OBJECT_BLOB,
|
||||
true, drm_property_free_blob);
|
||||
ret = __drm_mode_object_add(dev, &blob->base, DRM_MODE_OBJECT_BLOB,
|
||||
true, drm_property_free_blob);
|
||||
if (ret) {
|
||||
kfree(blob);
|
||||
return ERR_PTR(-EINVAL);
|
||||
|
Reference in New Issue
Block a user