mm: memcontrol: expose THP events on a per-memcg basis
Currently THP allocation events data is fairly opaque, since you can only get it system-wide. This patch makes it easier to reason about transparent hugepage behaviour on a per-memcg basis. For anonymous THP-backed pages, we already have MEMCG_RSS_HUGE in v1, which is used for v1's rss_huge [sic]. This is reused here as it's fairly involved to untangle NR_ANON_THPS right now to make it per-memcg, since right now some of this is delegated to rmap before we have any memcg actually assigned to the page. It's a good idea to rework that, but let's leave untangling THP allocation for a future patch. [akpm@linux-foundation.org: fix build] [chris@chrisdown.name: fix memcontrol build when THP is disabled] Link: http://lkml.kernel.org/r/20190131160802.GA5777@chrisdown.name Link: http://lkml.kernel.org/r/20190129205852.GA7310@chrisdown.name Signed-off-by: Chris Down <chris@chrisdown.name> Acked-by: Johannes Weiner <hannes@cmpxchg.org> Cc: Tejun Heo <tj@kernel.org> Cc: Roman Gushchin <guro@fb.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:

committed by
Linus Torvalds

parent
2bb0f34fe3
commit
1ff9e6e179
@@ -39,6 +39,7 @@
|
||||
#include <linux/shmem_fs.h>
|
||||
#include <linux/hugetlb.h>
|
||||
#include <linux/pagemap.h>
|
||||
#include <linux/vm_event_item.h>
|
||||
#include <linux/smp.h>
|
||||
#include <linux/page-flags.h>
|
||||
#include <linux/backing-dev.h>
|
||||
@@ -5571,6 +5572,15 @@ static int memory_stat_show(struct seq_file *m, void *v)
|
||||
seq_printf(m, "file_writeback %llu\n",
|
||||
(u64)acc.stat[NR_WRITEBACK] * PAGE_SIZE);
|
||||
|
||||
/*
|
||||
* TODO: We should eventually replace our own MEMCG_RSS_HUGE counter
|
||||
* with the NR_ANON_THP vm counter, but right now it's a pain in the
|
||||
* arse because it requires migrating the work out of rmap to a place
|
||||
* where the page->mem_cgroup is set up and stable.
|
||||
*/
|
||||
seq_printf(m, "anon_thp %llu\n",
|
||||
(u64)acc.stat[MEMCG_RSS_HUGE] * PAGE_SIZE);
|
||||
|
||||
for (i = 0; i < NR_LRU_LISTS; i++)
|
||||
seq_printf(m, "%s %llu\n", mem_cgroup_lru_names[i],
|
||||
(u64)acc.lru_pages[i] * PAGE_SIZE);
|
||||
@@ -5602,6 +5612,12 @@ static int memory_stat_show(struct seq_file *m, void *v)
|
||||
seq_printf(m, "pglazyfree %lu\n", acc.events[PGLAZYFREE]);
|
||||
seq_printf(m, "pglazyfreed %lu\n", acc.events[PGLAZYFREED]);
|
||||
|
||||
#ifdef CONFIG_TRANSPARENT_HUGEPAGE
|
||||
seq_printf(m, "thp_fault_alloc %lu\n", acc.events[THP_FAULT_ALLOC]);
|
||||
seq_printf(m, "thp_collapse_alloc %lu\n",
|
||||
acc.events[THP_COLLAPSE_ALLOC]);
|
||||
#endif /* CONFIG_TRANSPARENT_HUGEPAGE */
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user