ipv4: nexthop version of fib_info_nh_uses_dev
Similar to the last path, need to fix fib_info_nh_uses_dev for
external nexthops to avoid referencing multiple nh_grp structs.
Move the device check in fib_info_nh_uses_dev to a helper and
create a nexthop version that is called if the fib_info uses an
external nexthop.
Fixes: 430a049190
("nexthop: Add support for nexthop groups")
Signed-off-by: David Ahern <dsahern@gmail.com>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
af7888ad9e
commit
1fd1c768f3
@@ -309,17 +309,18 @@ bool fib_info_nh_uses_dev(struct fib_info *fi, const struct net_device *dev)
|
||||
{
|
||||
bool dev_match = false;
|
||||
#ifdef CONFIG_IP_ROUTE_MULTIPATH
|
||||
int ret;
|
||||
if (unlikely(fi->nh)) {
|
||||
dev_match = nexthop_uses_dev(fi->nh, dev);
|
||||
} else {
|
||||
int ret;
|
||||
|
||||
for (ret = 0; ret < fib_info_num_path(fi); ret++) {
|
||||
const struct fib_nh_common *nhc = fib_info_nhc(fi, ret);
|
||||
for (ret = 0; ret < fib_info_num_path(fi); ret++) {
|
||||
const struct fib_nh_common *nhc = fib_info_nhc(fi, ret);
|
||||
|
||||
if (nhc->nhc_dev == dev) {
|
||||
dev_match = true;
|
||||
break;
|
||||
} else if (l3mdev_master_ifindex_rcu(nhc->nhc_dev) == dev->ifindex) {
|
||||
dev_match = true;
|
||||
break;
|
||||
if (nhc_l3mdev_matches_dev(nhc, dev)) {
|
||||
dev_match = true;
|
||||
break;
|
||||
}
|
||||
}
|
||||
}
|
||||
#else
|
||||
|
Reference in New Issue
Block a user