drivers:net: dma_alloc_coherent: use __GFP_ZERO instead of memset(, 0)
Reduce the number of calls required to alloc a zeroed block of memory. Trivially reduces overall object size. Other changes around these removals o Neaten call argument alignment o Remove an unnecessary OOM message after dma_alloc_coherent failure o Remove unnecessary gfp_t stack variable Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
7f9421c264
commit
1f9061d27d
@@ -563,19 +563,16 @@ static int smsc_ircc_open(unsigned int fir_base, unsigned int sir_base, u8 dma,
|
||||
|
||||
self->rx_buff.head =
|
||||
dma_alloc_coherent(NULL, self->rx_buff.truesize,
|
||||
&self->rx_buff_dma, GFP_KERNEL);
|
||||
&self->rx_buff_dma, GFP_KERNEL | __GFP_ZERO);
|
||||
if (self->rx_buff.head == NULL)
|
||||
goto err_out2;
|
||||
|
||||
self->tx_buff.head =
|
||||
dma_alloc_coherent(NULL, self->tx_buff.truesize,
|
||||
&self->tx_buff_dma, GFP_KERNEL);
|
||||
&self->tx_buff_dma, GFP_KERNEL | __GFP_ZERO);
|
||||
if (self->tx_buff.head == NULL)
|
||||
goto err_out3;
|
||||
|
||||
memset(self->rx_buff.head, 0, self->rx_buff.truesize);
|
||||
memset(self->tx_buff.head, 0, self->tx_buff.truesize);
|
||||
|
||||
self->rx_buff.in_frame = FALSE;
|
||||
self->rx_buff.state = OUTSIDE_FRAME;
|
||||
self->tx_buff.data = self->tx_buff.head;
|
||||
|
Reference in New Issue
Block a user