Merge branch 'work.sock_recvmsg' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
Pull kern_recvmsg reduction from Al Viro: "kernel_recvmsg() is a set_fs()-using wrapper for sock_recvmsg(). In all but one case that is not needed - use of ITER_KVEC for ->msg_iter takes care of the data and does not care about set_fs(). The only exception is svc_udp_recvfrom() where we want cmsg to be store into kernel object; everything else can just use sock_recvmsg() and be done with that. A followup converting svc_udp_recvfrom() away from set_fs() (and killing kernel_recvmsg() off) is *NOT* in here - I'd like to hear what netdev folks think of the approach proposed in that followup)" * 'work.sock_recvmsg' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: tipc: switch to sock_recvmsg() smc: switch to sock_recvmsg() ipvs: switch to sock_recvmsg() mISDN: switch to sock_recvmsg() drbd: switch to sock_recvmsg() lustre lnet_sock_read(): switch to sock_recvmsg() cfs2: switch to sock_recvmsg() ncpfs: switch to sock_recvmsg() dlm: switch to sock_recvmsg() svc_recvfrom(): switch to sock_recvmsg()
This commit is contained in:
@@ -645,8 +645,10 @@ l1oip_socket_thread(void *data)
|
||||
{
|
||||
struct l1oip *hc = (struct l1oip *)data;
|
||||
int ret = 0;
|
||||
struct msghdr msg;
|
||||
struct sockaddr_in sin_rx;
|
||||
struct kvec iov;
|
||||
struct msghdr msg = {.msg_name = &sin_rx,
|
||||
.msg_namelen = sizeof(sin_rx)};
|
||||
unsigned char *recvbuf;
|
||||
size_t recvbuf_size = 1500;
|
||||
int recvlen;
|
||||
@@ -661,6 +663,9 @@ l1oip_socket_thread(void *data)
|
||||
goto fail;
|
||||
}
|
||||
|
||||
iov.iov_base = recvbuf;
|
||||
iov.iov_len = recvbuf_size;
|
||||
|
||||
/* make daemon */
|
||||
allow_signal(SIGTERM);
|
||||
|
||||
@@ -697,12 +702,6 @@ l1oip_socket_thread(void *data)
|
||||
goto fail;
|
||||
}
|
||||
|
||||
/* build receive message */
|
||||
msg.msg_name = &sin_rx;
|
||||
msg.msg_namelen = sizeof(sin_rx);
|
||||
msg.msg_control = NULL;
|
||||
msg.msg_controllen = 0;
|
||||
|
||||
/* build send message */
|
||||
hc->sendmsg.msg_name = &hc->sin_remote;
|
||||
hc->sendmsg.msg_namelen = sizeof(hc->sin_remote);
|
||||
@@ -719,12 +718,9 @@ l1oip_socket_thread(void *data)
|
||||
printk(KERN_DEBUG "%s: socket created and open\n",
|
||||
__func__);
|
||||
while (!signal_pending(current)) {
|
||||
struct kvec iov = {
|
||||
.iov_base = recvbuf,
|
||||
.iov_len = recvbuf_size,
|
||||
};
|
||||
recvlen = kernel_recvmsg(socket, &msg, &iov, 1,
|
||||
recvbuf_size, 0);
|
||||
iov_iter_kvec(&msg.msg_iter, READ | ITER_KVEC, &iov, 1,
|
||||
recvbuf_size);
|
||||
recvlen = sock_recvmsg(socket, &msg, 0);
|
||||
if (recvlen > 0) {
|
||||
l1oip_socket_parse(hc, &sin_rx, recvbuf, recvlen);
|
||||
} else {
|
||||
|
Reference in New Issue
Block a user