tty: Remove dev_err() usage after platform_get_irq()
We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // <smpl> @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) | platform_get_irq_byname(E, ...) ); if ( \( ret < 0 \| ret <= 0 \) ) { ( -if (ret != -EPROBE_DEFER) -{ ... -dev_err(...); -... } | ... -dev_err(...); ) ... } // </smpl> While we're here, remove braces on if statements that only have one statement (manually). Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Jiri Slaby <jslaby@suse.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> Link: https://lore.kernel.org/r/20190730181557.90391-45-swboyd@chromium.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
769d55c523
commit
1df2178681
@@ -928,11 +928,8 @@ static int stm32_init_port(struct stm32_port *stm32port,
|
||||
port->fifosize = stm32port->info->cfg.fifosize;
|
||||
|
||||
ret = platform_get_irq(pdev, 0);
|
||||
if (ret <= 0) {
|
||||
if (ret != -EPROBE_DEFER)
|
||||
dev_err(&pdev->dev, "Can't get event IRQ: %d\n", ret);
|
||||
return ret ? ret : -ENODEV;
|
||||
}
|
||||
if (ret <= 0)
|
||||
return ret ? : -ENODEV;
|
||||
port->irq = ret;
|
||||
|
||||
port->rs485_config = stm32_config_rs485;
|
||||
@@ -941,14 +938,8 @@ static int stm32_init_port(struct stm32_port *stm32port,
|
||||
|
||||
if (stm32port->info->cfg.has_wakeup) {
|
||||
stm32port->wakeirq = platform_get_irq(pdev, 1);
|
||||
if (stm32port->wakeirq <= 0 && stm32port->wakeirq != -ENXIO) {
|
||||
if (stm32port->wakeirq != -EPROBE_DEFER)
|
||||
dev_err(&pdev->dev,
|
||||
"Can't get event wake IRQ: %d\n",
|
||||
stm32port->wakeirq);
|
||||
return stm32port->wakeirq ? stm32port->wakeirq :
|
||||
-ENODEV;
|
||||
}
|
||||
if (stm32port->wakeirq <= 0 && stm32port->wakeirq != -ENXIO)
|
||||
return stm32port->wakeirq ? : -ENODEV;
|
||||
}
|
||||
|
||||
stm32port->fifoen = stm32port->info->cfg.has_fifo;
|
||||
|
Reference in New Issue
Block a user