PM: no suspend_prepare() phase
Remove the new suspend_prepare() phase. It doesn't seem very usable, has never been tested, doesn't address fault cleanup, and would need a sibling resume_complete(); plus there are no real use cases. It could be restored later if those issues get resolved. Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> Cc: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
1ebfd79eb4
commit
1d3a82af45
@@ -117,33 +117,6 @@ static int suspend_device_late(struct device *dev, pm_message_t state)
|
||||
return error;
|
||||
}
|
||||
|
||||
/**
|
||||
* device_prepare_suspend - save state and prepare to suspend
|
||||
*
|
||||
* NOTE! Devices cannot detach at this point - not only do we
|
||||
* hold the device list semaphores over the whole prepare, but
|
||||
* the whole point is to do non-invasive preparatory work, not
|
||||
* the actual suspend.
|
||||
*/
|
||||
int device_prepare_suspend(pm_message_t state)
|
||||
{
|
||||
int error = 0;
|
||||
struct device * dev;
|
||||
|
||||
down(&dpm_sem);
|
||||
down(&dpm_list_sem);
|
||||
list_for_each_entry_reverse(dev, &dpm_active, power.entry) {
|
||||
if (!dev->bus || !dev->bus->suspend_prepare)
|
||||
continue;
|
||||
error = dev->bus->suspend_prepare(dev, state);
|
||||
if (error)
|
||||
break;
|
||||
}
|
||||
up(&dpm_list_sem);
|
||||
up(&dpm_sem);
|
||||
return error;
|
||||
}
|
||||
|
||||
/**
|
||||
* device_suspend - Save state and stop all devices in system.
|
||||
* @state: Power state to put each device in.
|
||||
|
Reference in New Issue
Block a user