[SCSI] aha152x: Close narrow race in release
We were releasing the IRQ before removing the host, so commands could still be coming in which would never be seen by the interrupt handler. Just remove the host before releasing the IRQ to close this race. Signed-off-by: Matthew Wilcox <matthew@wil.cx> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
此提交包含在:
@@ -907,9 +907,10 @@ out_host_put:
|
||||
|
||||
void aha152x_release(struct Scsi_Host *shpnt)
|
||||
{
|
||||
if(!shpnt)
|
||||
if (!shpnt)
|
||||
return;
|
||||
|
||||
scsi_remove_host(shpnt);
|
||||
if (shpnt->irq)
|
||||
free_irq(shpnt->irq, shpnt);
|
||||
|
||||
@@ -923,7 +924,6 @@ void aha152x_release(struct Scsi_Host *shpnt)
|
||||
pnp_device_detach(HOSTDATA(shpnt)->pnpdev);
|
||||
#endif
|
||||
|
||||
scsi_remove_host(shpnt);
|
||||
list_del(&HOSTDATA(shpnt)->host_list);
|
||||
scsi_host_put(shpnt);
|
||||
}
|
||||
|
新增問題並參考
封鎖使用者