net: bridge: mdb: allow add/delete for host-joined groups
Currently this is needed only for user-space compatibility, so similar object adds/deletes as the dumped ones would succeed. Later it can be used for L2 mcast MAC add/delete. v3: fix compiler warning (DaveM) v2: don't send a notification when used from user-space, arm the group timer if no ports are left after host entry del Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
e77b0c84e3
commit
1bc844ee0f
@@ -148,8 +148,7 @@ static void br_multicast_group_expired(struct timer_list *t)
|
||||
if (!netif_running(br->dev) || timer_pending(&mp->timer))
|
||||
goto out;
|
||||
|
||||
mp->host_joined = false;
|
||||
br_mdb_notify(br->dev, NULL, &mp->addr, RTM_DELMDB, 0);
|
||||
br_multicast_host_leave(mp, true);
|
||||
|
||||
if (mp->ports)
|
||||
goto out;
|
||||
@@ -512,6 +511,27 @@ static bool br_port_group_equal(struct net_bridge_port_group *p,
|
||||
return ether_addr_equal(src, p->eth_addr);
|
||||
}
|
||||
|
||||
void br_multicast_host_join(struct net_bridge_mdb_entry *mp, bool notify)
|
||||
{
|
||||
if (!mp->host_joined) {
|
||||
mp->host_joined = true;
|
||||
if (notify)
|
||||
br_mdb_notify(mp->br->dev, NULL, &mp->addr,
|
||||
RTM_NEWMDB, 0);
|
||||
}
|
||||
mod_timer(&mp->timer, jiffies + mp->br->multicast_membership_interval);
|
||||
}
|
||||
|
||||
void br_multicast_host_leave(struct net_bridge_mdb_entry *mp, bool notify)
|
||||
{
|
||||
if (!mp->host_joined)
|
||||
return;
|
||||
|
||||
mp->host_joined = false;
|
||||
if (notify)
|
||||
br_mdb_notify(mp->br->dev, NULL, &mp->addr, RTM_DELMDB, 0);
|
||||
}
|
||||
|
||||
static int br_multicast_add_group(struct net_bridge *br,
|
||||
struct net_bridge_port *port,
|
||||
struct br_ip *group,
|
||||
@@ -534,11 +554,7 @@ static int br_multicast_add_group(struct net_bridge *br,
|
||||
goto err;
|
||||
|
||||
if (!port) {
|
||||
if (!mp->host_joined) {
|
||||
mp->host_joined = true;
|
||||
br_mdb_notify(br->dev, NULL, &mp->addr, RTM_NEWMDB, 0);
|
||||
}
|
||||
mod_timer(&mp->timer, now + br->multicast_membership_interval);
|
||||
br_multicast_host_join(mp, true);
|
||||
goto out;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user