drivers: use non-racy method for proc entries creation
Use proc_create()/proc_create_data() to make sure that ->proc_fops and ->data be setup before gluing PDE to main tree. Signed-off-by: Denis V. Lunev <den@openvz.org> Acked-by: Greg Kroah-Hartman <gregkh@suse.de> Cc: Alexey Dobriyan <adobriyan@gmail.com> Cc: "Eric W. Biederman" <ebiederm@xmission.com> Acked-by: Dmitry Torokhov <dtor@mail.ru> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:

committed by
Linus Torvalds

parent
0fd6894682
commit
1b50221738
@@ -520,12 +520,11 @@ static int __init toshiba_init(void)
|
||||
{
|
||||
struct proc_dir_entry *pde;
|
||||
|
||||
pde = create_proc_entry("toshiba", 0, NULL);
|
||||
pde = proc_create("toshiba", 0, NULL, &proc_toshiba_fops);
|
||||
if (!pde) {
|
||||
misc_deregister(&tosh_device);
|
||||
return -ENOMEM;
|
||||
}
|
||||
pde->proc_fops = &proc_toshiba_fops;
|
||||
}
|
||||
#endif
|
||||
|
||||
|
Reference in New Issue
Block a user