[PATCH] mutex subsystem, semaphore to mutex: VFS, ->i_sem
This patch converts the inode semaphore to a mutex. I have tested it on XFS and compiled as much as one can consider on an ia64. Anyway your luck with it might be different. Modified-by: Ingo Molnar <mingo@elte.hu> (finished the conversion) Signed-off-by: Jes Sorensen <jes@sgi.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:

committed by
Ingo Molnar

parent
794ee1baee
commit
1b1dcc1b57
@@ -99,7 +99,7 @@ static int create_dir(struct kobject * k, struct dentry * p,
|
||||
int error;
|
||||
umode_t mode = S_IFDIR| S_IRWXU | S_IRUGO | S_IXUGO;
|
||||
|
||||
down(&p->d_inode->i_sem);
|
||||
mutex_lock(&p->d_inode->i_mutex);
|
||||
*d = lookup_one_len(n, p, strlen(n));
|
||||
if (!IS_ERR(*d)) {
|
||||
error = sysfs_make_dirent(p->d_fsdata, *d, k, mode, SYSFS_DIR);
|
||||
@@ -122,7 +122,7 @@ static int create_dir(struct kobject * k, struct dentry * p,
|
||||
dput(*d);
|
||||
} else
|
||||
error = PTR_ERR(*d);
|
||||
up(&p->d_inode->i_sem);
|
||||
mutex_unlock(&p->d_inode->i_mutex);
|
||||
return error;
|
||||
}
|
||||
|
||||
@@ -246,7 +246,7 @@ static void remove_dir(struct dentry * d)
|
||||
struct dentry * parent = dget(d->d_parent);
|
||||
struct sysfs_dirent * sd;
|
||||
|
||||
down(&parent->d_inode->i_sem);
|
||||
mutex_lock(&parent->d_inode->i_mutex);
|
||||
d_delete(d);
|
||||
sd = d->d_fsdata;
|
||||
list_del_init(&sd->s_sibling);
|
||||
@@ -257,7 +257,7 @@ static void remove_dir(struct dentry * d)
|
||||
pr_debug(" o %s removing done (%d)\n",d->d_name.name,
|
||||
atomic_read(&d->d_count));
|
||||
|
||||
up(&parent->d_inode->i_sem);
|
||||
mutex_unlock(&parent->d_inode->i_mutex);
|
||||
dput(parent);
|
||||
}
|
||||
|
||||
@@ -286,7 +286,7 @@ void sysfs_remove_dir(struct kobject * kobj)
|
||||
return;
|
||||
|
||||
pr_debug("sysfs %s: removing dir\n",dentry->d_name.name);
|
||||
down(&dentry->d_inode->i_sem);
|
||||
mutex_lock(&dentry->d_inode->i_mutex);
|
||||
parent_sd = dentry->d_fsdata;
|
||||
list_for_each_entry_safe(sd, tmp, &parent_sd->s_children, s_sibling) {
|
||||
if (!sd->s_element || !(sd->s_type & SYSFS_NOT_PINNED))
|
||||
@@ -295,7 +295,7 @@ void sysfs_remove_dir(struct kobject * kobj)
|
||||
sysfs_drop_dentry(sd, dentry);
|
||||
sysfs_put(sd);
|
||||
}
|
||||
up(&dentry->d_inode->i_sem);
|
||||
mutex_unlock(&dentry->d_inode->i_mutex);
|
||||
|
||||
remove_dir(dentry);
|
||||
/**
|
||||
@@ -318,7 +318,7 @@ int sysfs_rename_dir(struct kobject * kobj, const char *new_name)
|
||||
down_write(&sysfs_rename_sem);
|
||||
parent = kobj->parent->dentry;
|
||||
|
||||
down(&parent->d_inode->i_sem);
|
||||
mutex_lock(&parent->d_inode->i_mutex);
|
||||
|
||||
new_dentry = lookup_one_len(new_name, parent, strlen(new_name));
|
||||
if (!IS_ERR(new_dentry)) {
|
||||
@@ -334,7 +334,7 @@ int sysfs_rename_dir(struct kobject * kobj, const char *new_name)
|
||||
error = -EEXIST;
|
||||
dput(new_dentry);
|
||||
}
|
||||
up(&parent->d_inode->i_sem);
|
||||
mutex_unlock(&parent->d_inode->i_mutex);
|
||||
up_write(&sysfs_rename_sem);
|
||||
|
||||
return error;
|
||||
@@ -345,9 +345,9 @@ static int sysfs_dir_open(struct inode *inode, struct file *file)
|
||||
struct dentry * dentry = file->f_dentry;
|
||||
struct sysfs_dirent * parent_sd = dentry->d_fsdata;
|
||||
|
||||
down(&dentry->d_inode->i_sem);
|
||||
mutex_lock(&dentry->d_inode->i_mutex);
|
||||
file->private_data = sysfs_new_dirent(parent_sd, NULL);
|
||||
up(&dentry->d_inode->i_sem);
|
||||
mutex_unlock(&dentry->d_inode->i_mutex);
|
||||
|
||||
return file->private_data ? 0 : -ENOMEM;
|
||||
|
||||
@@ -358,9 +358,9 @@ static int sysfs_dir_close(struct inode *inode, struct file *file)
|
||||
struct dentry * dentry = file->f_dentry;
|
||||
struct sysfs_dirent * cursor = file->private_data;
|
||||
|
||||
down(&dentry->d_inode->i_sem);
|
||||
mutex_lock(&dentry->d_inode->i_mutex);
|
||||
list_del_init(&cursor->s_sibling);
|
||||
up(&dentry->d_inode->i_sem);
|
||||
mutex_unlock(&dentry->d_inode->i_mutex);
|
||||
|
||||
release_sysfs_dirent(cursor);
|
||||
|
||||
@@ -436,7 +436,7 @@ static loff_t sysfs_dir_lseek(struct file * file, loff_t offset, int origin)
|
||||
{
|
||||
struct dentry * dentry = file->f_dentry;
|
||||
|
||||
down(&dentry->d_inode->i_sem);
|
||||
mutex_lock(&dentry->d_inode->i_mutex);
|
||||
switch (origin) {
|
||||
case 1:
|
||||
offset += file->f_pos;
|
||||
@@ -444,7 +444,7 @@ static loff_t sysfs_dir_lseek(struct file * file, loff_t offset, int origin)
|
||||
if (offset >= 0)
|
||||
break;
|
||||
default:
|
||||
up(&file->f_dentry->d_inode->i_sem);
|
||||
mutex_unlock(&file->f_dentry->d_inode->i_mutex);
|
||||
return -EINVAL;
|
||||
}
|
||||
if (offset != file->f_pos) {
|
||||
@@ -468,7 +468,7 @@ static loff_t sysfs_dir_lseek(struct file * file, loff_t offset, int origin)
|
||||
list_add_tail(&cursor->s_sibling, p);
|
||||
}
|
||||
}
|
||||
up(&dentry->d_inode->i_sem);
|
||||
mutex_unlock(&dentry->d_inode->i_mutex);
|
||||
return offset;
|
||||
}
|
||||
|
||||
@@ -483,4 +483,3 @@ struct file_operations sysfs_dir_operations = {
|
||||
EXPORT_SYMBOL_GPL(sysfs_create_dir);
|
||||
EXPORT_SYMBOL_GPL(sysfs_remove_dir);
|
||||
EXPORT_SYMBOL_GPL(sysfs_rename_dir);
|
||||
|
||||
|
Reference in New Issue
Block a user