xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

parisc/sticon: fix reverse colors

Browse Source 
commit bec05f33ebc1006899c6d3e59a00c58881fe7626 upstream.

sticon_build_attr() checked the reverse argument and flipped
background and foreground color, but returned the non-reverse
value afterwards. Fix this and also add two local variables
for foreground and background color to make the code easier
to read.

Signed-off-by: Sven Schnelle <svens@stackframe.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Sven Schnelle
2021-11-14 17:08:17 +01:00
committed by Greg Kroah-Hartman
parent 6adbc07ebc
commit 1ab297809d
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/video/console/sticon.c
View File

@@ -332,13 +332,13 @@ static u8 sticon_build_attr(struct vc_data *conp, u8 color,
bool blink, bool underline, bool reverse, bool blink, bool underline, bool reverse,
bool italic) bool italic)
{ {
u8 attr = ((color & 0x70) >> 1) | ((color & 7)); u8 fg = color & 7;
u8 bg = (color & 0x70) >> 4;
if (reverse) { if (reverse)
color = ((color >> 3) & 0x7) | ((color & 0x7) << 3); return (fg << 3) | bg;
} else
return (bg << 3) | fg;
return attr;
} }
static void sticon_invert_region(struct vc_data *conp, u16 *p, int count) static void sticon_invert_region(struct vc_data *conp, u16 *p, int count)