signal/hexagon: Use force_sig_fault as appropriate
Filling in struct siginfo before calling force_sig_info a tedious and error prone process, where once in a great while the wrong fields are filled out, and siginfo has been inconsistently cleared. Simplify this process by using the helper force_sig_fault. Which takes as a parameters all of the information it needs, ensures all of the fiddly bits of filling in struct siginfo are done properly and then calls force_sig_info. In short about a 5 line reduction in code for every time force_sig_info is called, which makes the calling function clearer. Cc: Richard Kuo <rkuo@codeaurora.org> Cc: linux-hexagon@vger.kernel.org Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
This commit is contained in:
@@ -412,11 +412,6 @@ void do_trap0(struct pt_regs *regs)
|
||||
case TRAP_DEBUG:
|
||||
/* Trap0 0xdb is debug breakpoint */
|
||||
if (user_mode(regs)) {
|
||||
struct siginfo info;
|
||||
|
||||
clear_siginfo(&info);
|
||||
info.si_signo = SIGTRAP;
|
||||
info.si_errno = 0;
|
||||
/*
|
||||
* Some architecures add some per-thread state
|
||||
* to distinguish between breakpoint traps and
|
||||
@@ -424,9 +419,8 @@ void do_trap0(struct pt_regs *regs)
|
||||
* set the si_code value appropriately, or we
|
||||
* may want to use a different trap0 flavor.
|
||||
*/
|
||||
info.si_code = TRAP_BRKPT;
|
||||
info.si_addr = (void __user *) pt_elr(regs);
|
||||
force_sig_info(SIGTRAP, &info, current);
|
||||
force_sig_fault(SIGTRAP, TRAP_BRKPT,
|
||||
(void __user *) pt_elr(regs), current);
|
||||
} else {
|
||||
#ifdef CONFIG_KGDB
|
||||
kgdb_handle_exception(pt_cause(regs), SIGTRAP,
|
||||
|
Reference in New Issue
Block a user