xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[media] lirc_dev: simplify if statement in lirc_add_to_buf

Browse Source 
The whole function is inside an 'if' statement
("if (ir->d.add_to_buf)").

Check the opposite of that statement at the beginning and exit,
this way we can have one level less of indentation.

Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Andi Shyti
2016-07-06 06:01:19 -03:00
committed by Mauro Carvalho Chehab
parent 7fe579d29f
commit 19e565397c
1 changed files with 15 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/media/rc/lirc_dev.c
View File

@@ -97,10 +97,12 @@ static void lirc_irctl_cleanup(struct irctl *ir)
*/ */
static int lirc_add_to_buf(struct irctl *ir) static int lirc_add_to_buf(struct irctl *ir)
{ {
if (ir->d.add_to_buf) { int res;
int res = -ENODATA;
int got_data = -1; int got_data = -1;
if (!ir->d.add_to_buf)
return 0;
/* /*
* service the device as long as it is returning * service the device as long as it is returning
* data and we have space * data and we have space
@@ -116,9 +118,6 @@ static int lirc_add_to_buf(struct irctl *ir)
return got_data ? 0 : res; return got_data ? 0 : res;
} }
return 0;
}
/* main function of the polling thread /* main function of the polling thread
*/ */
static int lirc_thread(void *irctl) static int lirc_thread(void *irctl)