rfkill: rewrite
This patch completely rewrites the rfkill core to address the following deficiencies: * all rfkill drivers need to implement polling where necessary rather than having one central implementation * updating the rfkill state cannot be done from arbitrary contexts, forcing drivers to use schedule_work and requiring lots of code * rfkill drivers need to keep track of soft/hard blocked internally -- the core should do this * the rfkill API has many unexpected quirks, for example being asymmetric wrt. alloc/free and register/unregister * rfkill can call back into a driver from within a function the driver called -- this is prone to deadlocks and generally should be avoided * rfkill-input pointlessly is a separate module * drivers need to #ifdef rfkill functions (unless they want to depend on or select RFKILL) -- rfkill should provide inlines that do nothing if it isn't compiled in * the rfkill structure is not opaque -- drivers need to initialise it correctly (lots of sanity checking code required) -- instead force drivers to pass the right variables to rfkill_alloc() * the documentation is hard to read because it always assumes the reader is completely clueless and contains way TOO MANY CAPS * the rfkill code needlessly uses a lot of locks and atomic operations in locked sections * fix LED trigger to actually change the LED when the radio state changes -- this wasn't done before Tested-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk> Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br> [thinkpad] Signed-off-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:

committed by
John W. Linville

parent
0f6399c4c5
commit
19d337dff9
@@ -253,7 +253,6 @@
|
||||
struct net_device;
|
||||
struct genl_info;
|
||||
struct wimax_dev;
|
||||
struct input_dev;
|
||||
|
||||
/**
|
||||
* struct wimax_dev - Generic WiMAX device
|
||||
@@ -293,8 +292,8 @@ struct input_dev;
|
||||
* See wimax_reset()'s documentation.
|
||||
*
|
||||
* @name: [fill] A way to identify this device. We need to register a
|
||||
* name with many subsystems (input for RFKILL, workqueue
|
||||
* creation, etc). We can't use the network device name as that
|
||||
* name with many subsystems (rfkill, workqueue creation, etc).
|
||||
* We can't use the network device name as that
|
||||
* might change and in some instances we don't know it yet (until
|
||||
* we don't call register_netdev()). So we generate an unique one
|
||||
* using the driver name and device bus id, place it here and use
|
||||
@@ -316,9 +315,6 @@ struct input_dev;
|
||||
*
|
||||
* @rfkill: [private] integration into the RF-Kill infrastructure.
|
||||
*
|
||||
* @rfkill_input: [private] virtual input device to process the
|
||||
* hardware RF Kill switches.
|
||||
*
|
||||
* @rf_sw: [private] State of the software radio switch (OFF/ON)
|
||||
*
|
||||
* @rf_hw: [private] State of the hardware radio switch (OFF/ON)
|
||||
|
Reference in New Issue
Block a user