isdn: Partially revert debug format string usage clean up
Commit35a4a57
("isdn: clean up debug format string usage") introduced a safeguard to avoid accidential format string interpolation of data when calling debugl1 or HiSax_putstatus. This did however not take into account VHiSax_putstatus (called by HiSax_putstatus) does *not* call vsprintf if the head parameter is NULL - the format string is treated as plain text then instead. As a result, the string "%s" is processed literally, and the actual information is lost. This affects the isdnlog userspace program which stopped logging information since that commit. So revert the HiSax_putstatus invocations to the previous state. Fixes:35a4a5733b
("isdn: clean up debug format string usage") Cc: Kees Cook <keescook@chromium.org> Cc: Karsten Keil <isdn@linux-pingi.de> Signed-off-by: Christoph Biedl <linux-kernel.bfrz@manchmal.in-ulm.de> Signed-off-by: David S. Miller <davem@davemloft.net>
Šī revīzija ir iekļauta:

revīziju iesūtīja
David S. Miller

vecāks
8c7188b234
revīzija
19cebbcb04
@@ -674,7 +674,7 @@ receive_emsg(struct IsdnCardState *cs)
|
||||
ptr--;
|
||||
*ptr++ = '\n';
|
||||
*ptr = 0;
|
||||
HiSax_putstatus(cs, NULL, "%s", cs->dlog);
|
||||
HiSax_putstatus(cs, NULL, cs->dlog);
|
||||
} else
|
||||
HiSax_putstatus(cs, "LogEcho: ", "warning Frame too big (%d)", skb->len);
|
||||
}
|
||||
|
Atsaukties uz šo jaunā problēmā
Block a user