nvmet_fc: add req_release to lldd api
With the advent of the opdone calls changing context, the lldd can no longer assume that once the op->done call returns for RSP operations that the request struct is no longer being accessed. As such, revise the lldd api for a req_release callback that the transport will call when the job is complete. This will also be used with abort cases. Fixed text in api header for change in io complete semantics. Revised lpfc to support the new req_release api. Signed-off-by: James Smart <james.smart@broadcom.com> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
This commit is contained in:

committed by
Christoph Hellwig

parent
39498faef7
commit
19b58d9473
@@ -492,14 +492,18 @@ fcloop_fcp_op(struct nvmet_fc_target_port *tgtport,
|
||||
tgt_fcpreq->fcp_error = fcp_err;
|
||||
tgt_fcpreq->done(tgt_fcpreq);
|
||||
|
||||
if ((!fcp_err) && (op == NVMET_FCOP_RSP ||
|
||||
op == NVMET_FCOP_READDATA_RSP ||
|
||||
op == NVMET_FCOP_ABORT))
|
||||
schedule_work(&tfcp_req->work);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static void
|
||||
fcloop_fcp_req_release(struct nvmet_fc_target_port *tgtport,
|
||||
struct nvmefc_tgt_fcp_req *tgt_fcpreq)
|
||||
{
|
||||
struct fcloop_fcpreq *tfcp_req = tgt_fcp_req_to_fcpreq(tgt_fcpreq);
|
||||
|
||||
schedule_work(&tfcp_req->work);
|
||||
}
|
||||
|
||||
static void
|
||||
fcloop_ls_abort(struct nvme_fc_local_port *localport,
|
||||
struct nvme_fc_remote_port *remoteport,
|
||||
@@ -570,6 +574,7 @@ struct nvmet_fc_target_template tgttemplate = {
|
||||
.targetport_delete = fcloop_targetport_delete,
|
||||
.xmt_ls_rsp = fcloop_xmt_ls_rsp,
|
||||
.fcp_op = fcloop_fcp_op,
|
||||
.fcp_req_release = fcloop_fcp_req_release,
|
||||
.max_hw_queues = FCLOOP_HW_QUEUES,
|
||||
.max_sgl_segments = FCLOOP_SGL_SEGS,
|
||||
.max_dif_sgl_segments = FCLOOP_SGL_SEGS,
|
||||
|
Reference in New Issue
Block a user