mmc: vub300: fix an error code
commit b44f9da81783fda72632ef9b0d05ea3f3ca447a5 upstream.
This error path should return -EINVAL instead of success.
Fixes: 88095e7b47
("mmc: Add new VUB300 USB-to-SD/SDIO/MMC driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/0769d30c-ad80-421b-bf5d-7d6f5d85604e@moroto.mountain
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
3a4431014c
commit
198366a5ff
@@ -2311,6 +2311,7 @@ static int vub300_probe(struct usb_interface *interface,
|
|||||||
vub300->read_only =
|
vub300->read_only =
|
||||||
(0x0010 & vub300->system_port_status.port_flags) ? 1 : 0;
|
(0x0010 & vub300->system_port_status.port_flags) ? 1 : 0;
|
||||||
} else {
|
} else {
|
||||||
|
retval = -EINVAL;
|
||||||
goto error5;
|
goto error5;
|
||||||
}
|
}
|
||||||
usb_set_intfdata(interface, vub300);
|
usb_set_intfdata(interface, vub300);
|
||||||
|
Reference in New Issue
Block a user