[PATCH] EDAC: protect memory controller list
- Fix code so we always hold mem_ctls_mutex while we are stepping through the list of mem_ctl_info structures. Otherwise bad things may happen if one task is stepping through the list while another task is modifying it. We may eventually want to use reference counting to manage the mem_ctl_info structures. In the meantime we may as well fix this bug. - Don't disable interrupts while we are walking the list of mem_ctl_info structures in check_mc_devices(). This is unnecessary. Signed-off-by: David S. Peterson <dsp@llnl.gov> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:

committed by
Linus Torvalds

orang tua
472678ebd3
melakukan
18dbc337af
@@ -452,7 +452,7 @@ static void __devexit i82875p_remove_one(struct pci_dev *pdev)
|
||||
|
||||
debugf0("%s()\n", __func__);
|
||||
|
||||
if ((mci = edac_mc_find_mci_by_pdev(pdev)) == NULL)
|
||||
if ((mci = edac_mc_del_mc(pdev)) == NULL)
|
||||
return;
|
||||
|
||||
pvt = (struct i82875p_pvt *) mci->pvt_info;
|
||||
@@ -467,9 +467,6 @@ static void __devexit i82875p_remove_one(struct pci_dev *pdev)
|
||||
pci_dev_put(pvt->ovrfl_pdev);
|
||||
}
|
||||
|
||||
if (edac_mc_del_mc(mci))
|
||||
return;
|
||||
|
||||
edac_mc_free(mci);
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user