lib/crc7: Shift crc7() output left 1 bit
This eliminates a 1-bit left shift in every single caller, and makes the inner loop of the CRC computation more efficient. Renamed crc7 to crc7_be (big-endian) since the interface changed. Also purged #include <linux/crc7.h> from files that don't use it at all. Signed-off-by: George Spelvin <linux@horizon.com> Reviewed-by: Pavel Machek <pavel@ucw.cz> Acked-by: Ulf Hansson <ulf.hansson@linaro.org> Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:

committato da
John W. Linville

parent
d91a48cbae
commit
1836eea209
@@ -2,7 +2,6 @@
|
||||
|
||||
#include <linux/module.h>
|
||||
#include <linux/slab.h>
|
||||
#include <linux/crc7.h>
|
||||
|
||||
#include "wl1251.h"
|
||||
#include "reg.h"
|
||||
|
@@ -2,7 +2,6 @@
|
||||
|
||||
#include <linux/module.h>
|
||||
#include <linux/slab.h>
|
||||
#include <linux/crc7.h>
|
||||
#include <linux/etherdevice.h>
|
||||
|
||||
#include "wl1251.h"
|
||||
|
@@ -122,8 +122,7 @@ static void wl1251_spi_wake(struct wl1251 *wl)
|
||||
crc[3] = cmd[6];
|
||||
crc[4] = cmd[5];
|
||||
|
||||
cmd[4] |= crc7(0, crc, WSPI_INIT_CMD_CRC_LEN) << 1;
|
||||
cmd[4] |= WSPI_INIT_CMD_END;
|
||||
cmd[4] = crc7_be(0, crc, WSPI_INIT_CMD_CRC_LEN) | WSPI_INIT_CMD_END;
|
||||
|
||||
t.tx_buf = cmd;
|
||||
t.len = WSPI_INIT_CMD_LEN;
|
||||
|
@@ -151,8 +151,7 @@ static void wl12xx_spi_init(struct device *child)
|
||||
crc[3] = cmd[6];
|
||||
crc[4] = cmd[5];
|
||||
|
||||
cmd[4] |= crc7(0, crc, WSPI_INIT_CMD_CRC_LEN) << 1;
|
||||
cmd[4] |= WSPI_INIT_CMD_END;
|
||||
cmd[4] = crc7_be(0, crc, WSPI_INIT_CMD_CRC_LEN) | WSPI_INIT_CMD_END;
|
||||
|
||||
t.tx_buf = cmd;
|
||||
t.len = WSPI_INIT_CMD_LEN;
|
||||
|
Fai riferimento in un nuovo problema
Block a user