drm: add minor-lookup/release helpers
Instead of accessing drm_minors_idr directly, this adds a small helper to hide the internals. This will help us later to remove the drm_global_mutex requirement for minor-lookup. Furthermore, this also makes sure that minor->dev is always valid and takes a reference-count to the device as long as the minor is used in an open-file. This way, "struct file*"->private_data->dev is guaranteed to be valid (which it has to, as we cannot reset it). Signed-off-by: David Herrmann <dh.herrmann@gmail.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
This commit is contained in:
@@ -355,6 +355,45 @@ static void drm_unplug_minor(struct drm_minor *minor)
|
||||
idr_remove(&drm_minors_idr, minor->index);
|
||||
}
|
||||
|
||||
/**
|
||||
* drm_minor_acquire - Acquire a DRM minor
|
||||
* @minor_id: Minor ID of the DRM-minor
|
||||
*
|
||||
* Looks up the given minor-ID and returns the respective DRM-minor object. The
|
||||
* refence-count of the underlying device is increased so you must release this
|
||||
* object with drm_minor_release().
|
||||
*
|
||||
* As long as you hold this minor, it is guaranteed that the object and the
|
||||
* minor->dev pointer will stay valid! However, the device may get unplugged and
|
||||
* unregistered while you hold the minor.
|
||||
*
|
||||
* Returns:
|
||||
* Pointer to minor-object with increased device-refcount, or PTR_ERR on
|
||||
* failure.
|
||||
*/
|
||||
struct drm_minor *drm_minor_acquire(unsigned int minor_id)
|
||||
{
|
||||
struct drm_minor *minor;
|
||||
|
||||
minor = idr_find(&drm_minors_idr, minor_id);
|
||||
if (!minor)
|
||||
return ERR_PTR(-ENODEV);
|
||||
|
||||
drm_dev_ref(minor->dev);
|
||||
return minor;
|
||||
}
|
||||
|
||||
/**
|
||||
* drm_minor_release - Release DRM minor
|
||||
* @minor: Pointer to DRM minor object
|
||||
*
|
||||
* Release a minor that was previously acquired via drm_minor_acquire().
|
||||
*/
|
||||
void drm_minor_release(struct drm_minor *minor)
|
||||
{
|
||||
drm_dev_unref(minor->dev);
|
||||
}
|
||||
|
||||
/**
|
||||
* drm_put_minor - Destroy DRM minor
|
||||
* @minor: Minor to destroy
|
||||
|
Reference in New Issue
Block a user