[MIPS] IRQ cleanups
This is a big irq cleanup patch. * Use set_irq_chip() to register irq_chip. * Initialize .mask, .unmask, .mask_ack field. Functions for these method are already exist in most case. * Do not initialize .startup, .shutdown, .enable, .disable fields if default routines provided by irq_chip_set_defaults() were suitable. * Remove redundant irq_desc initializations. * Remove unnecessary local_irq_save/local_irq_restore, spin_lock. With this cleanup, it would be easy to switch to slightly lightwait irq flow handlers (handle_level_irq(), etc.) instead of __do_IRQ(). Though whole this patch is quite large, changes in each irq_chip are not quite simple. Please review and test on your platform. Thanks. Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
This commit is contained in:

committed by
Ralf Baechle

orang tua
c87b6ebaea
melakukan
1603b5aca4
@@ -53,14 +53,6 @@ vrc5477_irq_disable(unsigned int irq)
|
||||
ll_vrc5477_irq_disable(irq - vrc5477_irq_base);
|
||||
}
|
||||
|
||||
static unsigned int vrc5477_irq_startup(unsigned int irq)
|
||||
{
|
||||
vrc5477_irq_enable(irq);
|
||||
return 0;
|
||||
}
|
||||
|
||||
#define vrc5477_irq_shutdown vrc5477_irq_disable
|
||||
|
||||
static void
|
||||
vrc5477_irq_ack(unsigned int irq)
|
||||
{
|
||||
@@ -91,11 +83,10 @@ vrc5477_irq_end(unsigned int irq)
|
||||
|
||||
struct irq_chip vrc5477_irq_controller = {
|
||||
.typename = "vrc5477_irq",
|
||||
.startup = vrc5477_irq_startup,
|
||||
.shutdown = vrc5477_irq_shutdown,
|
||||
.enable = vrc5477_irq_enable,
|
||||
.disable = vrc5477_irq_disable,
|
||||
.ack = vrc5477_irq_ack,
|
||||
.mask = vrc5477_irq_disable,
|
||||
.mask_ack = vrc5477_irq_ack,
|
||||
.unmask = vrc5477_irq_enable,
|
||||
.end = vrc5477_irq_end
|
||||
};
|
||||
|
||||
@@ -103,12 +94,8 @@ void __init vrc5477_irq_init(u32 irq_base)
|
||||
{
|
||||
u32 i;
|
||||
|
||||
for (i= irq_base; i< irq_base+ NUM_5477_IRQ; i++) {
|
||||
irq_desc[i].status = IRQ_DISABLED;
|
||||
irq_desc[i].action = NULL;
|
||||
irq_desc[i].depth = 1;
|
||||
irq_desc[i].chip = &vrc5477_irq_controller;
|
||||
}
|
||||
for (i= irq_base; i< irq_base+ NUM_5477_IRQ; i++)
|
||||
set_irq_chip(i, &vrc5477_irq_controller);
|
||||
|
||||
vrc5477_irq_base = irq_base;
|
||||
}
|
||||
|
Reference in New Issue
Block a user