gpio: Remove dev_err() usage after platform_get_irq()
We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // <smpl> @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) | platform_get_irq_byname(E, ...) ); if ( \( ret < 0 \| ret <= 0 \) ) { ( -if (ret != -EPROBE_DEFER) -{ ... -dev_err(...); -... } | ... -dev_err(...); ) ... } // </smpl> While we're here, remove braces on if statements that only have one statement (manually). Cc: linux-gpio@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> Link: https://lore.kernel.org/r/20190730181557.90391-16-swboyd@chromium.org Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Cette révision appartient à :

révisé par
Linus Walleij

Parent
74d2d0e687
révision
15bddb7d78
@@ -408,8 +408,6 @@ static int grgpio_probe(struct platform_device *ofdev)
|
||||
* Continue without irq functionality for that
|
||||
* gpio line
|
||||
*/
|
||||
dev_err(priv->dev,
|
||||
"Failed to get irq for offset %d\n", i);
|
||||
continue;
|
||||
}
|
||||
priv->uirqs[lirq->index].uirq = ret;
|
||||
|
Référencer dans un nouveau ticket
Bloquer un utilisateur