[AX.25]: Fix default address and broadcast address initialization.
Only the callsign but not the SSID part of an AX.25 address is ASCII based but Linux by initializes the SSID which should be just a 4-bit number from ASCII anyway. Fix that and convert the code to use a shared constant for both default addresses. While at it, use the same style for null_ax25_address also. Signed-off-by: Ralf Baechle <ralf@linux-mips.org> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
e8cc49bb0f
commit
15b1c0e822
@@ -88,11 +88,6 @@
|
||||
|
||||
static char banner[] __initdata = KERN_INFO "AX.25: bpqether driver version 004\n";
|
||||
|
||||
static unsigned char ax25_bcast[AX25_ADDR_LEN] =
|
||||
{'Q' << 1, 'S' << 1, 'T' << 1, ' ' << 1, ' ' << 1, ' ' << 1, '0' << 1};
|
||||
static unsigned char ax25_defaddr[AX25_ADDR_LEN] =
|
||||
{'L' << 1, 'I' << 1, 'N' << 1, 'U' << 1, 'X' << 1, ' ' << 1, '1' << 1};
|
||||
|
||||
static char bcast_addr[6]={0xFF,0xFF,0xFF,0xFF,0xFF,0xFF};
|
||||
|
||||
static char bpq_eth_addr[6];
|
||||
@@ -487,8 +482,8 @@ static void bpq_setup(struct net_device *dev)
|
||||
dev->do_ioctl = bpq_ioctl;
|
||||
dev->destructor = free_netdev;
|
||||
|
||||
memcpy(dev->broadcast, ax25_bcast, AX25_ADDR_LEN);
|
||||
memcpy(dev->dev_addr, ax25_defaddr, AX25_ADDR_LEN);
|
||||
memcpy(dev->broadcast, &ax25_bcast, AX25_ADDR_LEN);
|
||||
memcpy(dev->dev_addr, &ax25_defaddr, AX25_ADDR_LEN);
|
||||
|
||||
dev->flags = 0;
|
||||
|
||||
|
Reference in New Issue
Block a user