[AX.25]: Fix default address and broadcast address initialization.
Only the callsign but not the SSID part of an AX.25 address is ASCII based but Linux by initializes the SSID which should be just a 4-bit number from ASCII anyway. Fix that and convert the code to use a shared constant for both default addresses. While at it, use the same style for null_ax25_address also. Signed-off-by: Ralf Baechle <ralf@linux-mips.org> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
e8cc49bb0f
commit
15b1c0e822
@@ -1141,12 +1141,6 @@ static int baycom_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
|
||||
*/
|
||||
static void baycom_probe(struct net_device *dev)
|
||||
{
|
||||
static char ax25_bcast[AX25_ADDR_LEN] = {
|
||||
'Q' << 1, 'S' << 1, 'T' << 1, ' ' << 1, ' ' << 1, ' ' << 1, '0' << 1
|
||||
};
|
||||
static char ax25_nocall[AX25_ADDR_LEN] = {
|
||||
'L' << 1, 'I' << 1, 'N' << 1, 'U' << 1, 'X' << 1, ' ' << 1, '1' << 1
|
||||
};
|
||||
const struct hdlcdrv_channel_params dflt_ch_params = {
|
||||
20, 2, 10, 40, 0
|
||||
};
|
||||
@@ -1182,8 +1176,8 @@ static void baycom_probe(struct net_device *dev)
|
||||
dev->hard_header_len = AX25_MAX_HEADER_LEN + AX25_BPQ_HEADER_LEN;
|
||||
dev->mtu = AX25_DEF_PACLEN; /* eth_mtu is the default */
|
||||
dev->addr_len = AX25_ADDR_LEN; /* sizeof an ax.25 address */
|
||||
memcpy(dev->broadcast, ax25_bcast, AX25_ADDR_LEN);
|
||||
memcpy(dev->dev_addr, ax25_nocall, AX25_ADDR_LEN);
|
||||
memcpy(dev->broadcast, &ax25_bcast, AX25_ADDR_LEN);
|
||||
memcpy(dev->dev_addr, &ax25_nocall, AX25_ADDR_LEN);
|
||||
dev->tx_queue_len = 16;
|
||||
|
||||
/* New style flags */
|
||||
|
Reference in New Issue
Block a user