IB/mlx5: Modify QP debugging prints
Add debugging prints to the modify QP verb to help understand the cause a returned error. Reviewed-by: Leon Romanovsky <leonro@mellanox.com> Signed-off-by: Haggai Eran <haggaie@mellanox.com> Signed-off-by: Doug Ledford <dledford@redhat.com>
This commit is contained in:

committed by
Doug Ledford

parent
b11a4f9cde
commit
158abf862a
@@ -2197,8 +2197,10 @@ static int __mlx5_ib_modify_qp(struct ib_qp *ibqp,
|
|||||||
|
|
||||||
context = &in->ctx;
|
context = &in->ctx;
|
||||||
err = to_mlx5_st(ibqp->qp_type);
|
err = to_mlx5_st(ibqp->qp_type);
|
||||||
if (err < 0)
|
if (err < 0) {
|
||||||
|
mlx5_ib_dbg(dev, "unsupported qp type %d\n", ibqp->qp_type);
|
||||||
goto out;
|
goto out;
|
||||||
|
}
|
||||||
|
|
||||||
context->flags = cpu_to_be32(err << 16);
|
context->flags = cpu_to_be32(err << 16);
|
||||||
|
|
||||||
@@ -2418,30 +2420,45 @@ int mlx5_ib_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,
|
|||||||
|
|
||||||
if (ibqp->qp_type != MLX5_IB_QPT_REG_UMR &&
|
if (ibqp->qp_type != MLX5_IB_QPT_REG_UMR &&
|
||||||
!ib_modify_qp_is_ok(cur_state, new_state, ibqp->qp_type, attr_mask,
|
!ib_modify_qp_is_ok(cur_state, new_state, ibqp->qp_type, attr_mask,
|
||||||
ll))
|
ll)) {
|
||||||
|
mlx5_ib_dbg(dev, "invalid QP state transition from %d to %d, qp_type %d, attr_mask 0x%x\n",
|
||||||
|
cur_state, new_state, ibqp->qp_type, attr_mask);
|
||||||
goto out;
|
goto out;
|
||||||
|
}
|
||||||
|
|
||||||
if ((attr_mask & IB_QP_PORT) &&
|
if ((attr_mask & IB_QP_PORT) &&
|
||||||
(attr->port_num == 0 ||
|
(attr->port_num == 0 ||
|
||||||
attr->port_num > MLX5_CAP_GEN(dev->mdev, num_ports)))
|
attr->port_num > MLX5_CAP_GEN(dev->mdev, num_ports))) {
|
||||||
|
mlx5_ib_dbg(dev, "invalid port number %d. number of ports is %d\n",
|
||||||
|
attr->port_num, dev->num_ports);
|
||||||
goto out;
|
goto out;
|
||||||
|
}
|
||||||
|
|
||||||
if (attr_mask & IB_QP_PKEY_INDEX) {
|
if (attr_mask & IB_QP_PKEY_INDEX) {
|
||||||
port = attr_mask & IB_QP_PORT ? attr->port_num : qp->port;
|
port = attr_mask & IB_QP_PORT ? attr->port_num : qp->port;
|
||||||
if (attr->pkey_index >=
|
if (attr->pkey_index >=
|
||||||
dev->mdev->port_caps[port - 1].pkey_table_len)
|
dev->mdev->port_caps[port - 1].pkey_table_len) {
|
||||||
|
mlx5_ib_dbg(dev, "invalid pkey index %d\n",
|
||||||
|
attr->pkey_index);
|
||||||
goto out;
|
goto out;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
if (attr_mask & IB_QP_MAX_QP_RD_ATOMIC &&
|
if (attr_mask & IB_QP_MAX_QP_RD_ATOMIC &&
|
||||||
attr->max_rd_atomic >
|
attr->max_rd_atomic >
|
||||||
(1 << MLX5_CAP_GEN(dev->mdev, log_max_ra_res_qp)))
|
(1 << MLX5_CAP_GEN(dev->mdev, log_max_ra_res_qp))) {
|
||||||
|
mlx5_ib_dbg(dev, "invalid max_rd_atomic value %d\n",
|
||||||
|
attr->max_rd_atomic);
|
||||||
goto out;
|
goto out;
|
||||||
|
}
|
||||||
|
|
||||||
if (attr_mask & IB_QP_MAX_DEST_RD_ATOMIC &&
|
if (attr_mask & IB_QP_MAX_DEST_RD_ATOMIC &&
|
||||||
attr->max_dest_rd_atomic >
|
attr->max_dest_rd_atomic >
|
||||||
(1 << MLX5_CAP_GEN(dev->mdev, log_max_ra_req_qp)))
|
(1 << MLX5_CAP_GEN(dev->mdev, log_max_ra_req_qp))) {
|
||||||
|
mlx5_ib_dbg(dev, "invalid max_dest_rd_atomic value %d\n",
|
||||||
|
attr->max_dest_rd_atomic);
|
||||||
goto out;
|
goto out;
|
||||||
|
}
|
||||||
|
|
||||||
if (cur_state == new_state && cur_state == IB_QPS_RESET) {
|
if (cur_state == new_state && cur_state == IB_QPS_RESET) {
|
||||||
err = 0;
|
err = 0;
|
||||||
|
Reference in New Issue
Block a user