xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm: tweak drm_print_bits()

Browse Source 
There is little reason for the from/to logic, printing a subset of
the bits can be done by simply shifting/masking value if needed.

Also use for_each_set_bit().

Suggested-by: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Sean Paul <sean@poorly.run>
Link: http://patchwork.freedesktop.org/patch/msgid/20190923065814.4797-1-kraxel@redhat.com
This commit is contained in:
Gerd Hoffmann
2019-09-23 08:58:14 +02:00
parent 67c1a02048
commit 141f6357f4
3 changed files with 13 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/gpu/drm/drm_print.c
View File

@@ -189,28 +189,26 @@ EXPORT_SYMBOL(drm_printf);
* drm_print_bits - print bits to a &drm_printer stream
*
* Print bits (in flag fields for example) in human readable form.
* The first name in the @bits array is for the bit indexed by @from.
*
* @p: the &drm_printer
* @value: field value.
* @bits: Array with bit names.
* @from: start of bit range to print (inclusive).
* @to: end of bit range to print (exclusive).
* @nbits: Size of bit names array.
*/
void drm_print_bits(struct drm_printer *p,
unsigned long value, const char *bits[],
unsigned int from, unsigned int to)
void drm_print_bits(struct drm_printer *p, unsigned long value,
const char * const bits[], unsigned int nbits)
{
bool first = true;
unsigned int i;
for (i = from; i < to; i++) {
if (!(value & (1 << i)))
continue;
if (WARN_ON_ONCE(!bits[i-from]))
if (WARN_ON_ONCE(nbits > BITS_PER_TYPE(value)))
nbits = BITS_PER_TYPE(value);
for_each_set_bit(i, &value, nbits) {
if (WARN_ON_ONCE(!bits[i]))
continue;
drm_printf(p, "%s%s", first ? "" : ",",
bits[i-from]);
bits[i]);
first = false;
}
if (first)