xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cdc-wdm: cleanup debug messages

Browse Source 
Dynamic debugging will already add the function (and the line number)
to a debug message if one requests that. It makes no sense to add
them unconditionally in a driver.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Oliver Neukum
2016-08-15 11:17:55 +02:00
committed by Greg Kroah-Hartman
parent ff7bbff3bc
commit 13a88bf5e0
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/usb/class/cdc-wdm.c
View File

@@ -314,8 +314,7 @@ static void wdm_int_callback(struct urb *urb)
&& !test_bit(WDM_DISCONNECTING, &desc->flags) && !test_bit(WDM_DISCONNECTING, &desc->flags)
&& !test_bit(WDM_SUSPENDING, &desc->flags)) { && !test_bit(WDM_SUSPENDING, &desc->flags)) {
rv = usb_submit_urb(desc->response, GFP_ATOMIC); rv = usb_submit_urb(desc->response, GFP_ATOMIC);
dev_dbg(&desc->intf->dev, "%s: usb_submit_urb %d", dev_dbg(&desc->intf->dev, "submit response URB %d", rv);
__func__, rv);
} }
spin_unlock(&desc->iuspin); spin_unlock(&desc->iuspin);
if (rv < 0) { if (rv < 0) {
@@ -574,7 +573,7 @@ retry:
} }
if (!desc->reslength) { /* zero length read */ if (!desc->reslength) { /* zero length read */
dev_dbg(&desc->intf->dev, "%s: zero length - clearing WDM_READ\n", __func__); dev_dbg(&desc->intf->dev, "zero length - clearing WDM_READ");
clear_bit(WDM_READ, &desc->flags); clear_bit(WDM_READ, &desc->flags);
rv = service_outstanding_interrupt(desc); rv = service_outstanding_interrupt(desc);
spin_unlock_irq(&desc->iuspin); spin_unlock_irq(&desc->iuspin);
@@ -1081,7 +1080,7 @@ static void wdm_disconnect(struct usb_interface *intf)
if (!desc->count) if (!desc->count)
cleanup(desc); cleanup(desc);
else else
dev_dbg(&intf->dev, "%s: %d open files - postponing cleanup\n", __func__, desc->count); dev_dbg(&intf->dev, "%d open files - postponing cleanup\n", desc->count);
mutex_unlock(&wdm_mutex); mutex_unlock(&wdm_mutex);
} }