xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/omap: Remove unneeded fallback for missing .check_timings()

Browse Source 
The .check_timings() operation is present in all panels and connectors.
The fallback that uses .get_timings() in the absence of .check_timings()
is thus unneeded.

While it could be argued that the fallback implements a useful check
that should be extended to cover all fixed-resolution panels, the code
is currently unused and gets in the way of the ongoing refactoring.
Remove it, a similar feature can always be added later.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
This commit is contained in:
Laurent Pinchart
2018-06-06 00:04:39 +03:00
committed by Tomi Valkeinen
parent bb23800c88
commit 138fe53ef8
2 changed files with 3 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/gpu/drm/omapdrm/omap_encoder.c
View File

@@ -101,21 +101,9 @@ static int omap_encoder_update(struct drm_encoder *encoder,
struct omap_dss_device *dssdev = omap_encoder->display;
int ret;
if (dssdev->ops->check_timings) {
ret = dssdev->ops->check_timings(dssdev, vm);
} else {
struct videomode t = {0};
dssdev->ops->get_timings(dssdev, &t);
if (memcmp(vm, &t, sizeof(*vm)))
ret = -EINVAL;
else
ret = 0;
}
ret = dssdev->ops->check_timings(dssdev, vm);
if (ret) {
dev_err(dev->dev, "could not set timings: %d\n", ret);
dev_err(dev->dev, "invalid timings: %d\n", ret);
return ret;
}