ALSA: hda - hdmi: Add error-checking to some codec reads
Add error checks to HBR status reads (both generic and ATI/AMD) and ATI/AMD codec reads for ELD generation. Unchecked errors in these just caused more errors later on (invalid codec writes for the HBR ones and ELD parsing errors for the ATI/AMD ELD ones), but it is better to catch them earlier. Signed-off-by: Anssi Hannula <anssi.hannula@iki.fi> Signed-off-by: Takashi Iwai <tiwai@suse.de>
此提交包含在:
@@ -1247,6 +1247,9 @@ static int hdmi_pin_hbr_setup(struct hda_codec *codec, hda_nid_t pin_nid,
|
||||
pinctl = snd_hda_codec_read(codec, pin_nid, 0,
|
||||
AC_VERB_GET_PIN_WIDGET_CONTROL, 0);
|
||||
|
||||
if (pinctl < 0)
|
||||
return hbr ? -EINVAL : 0;
|
||||
|
||||
new_pinctl = pinctl & ~AC_PINCTL_EPT;
|
||||
if (hbr)
|
||||
new_pinctl |= AC_PINCTL_EPT_HBR;
|
||||
@@ -3091,7 +3094,7 @@ static int atihdmi_pin_hbr_setup(struct hda_codec *codec, hda_nid_t pin_nid,
|
||||
int hbr_ctl, hbr_ctl_new;
|
||||
|
||||
hbr_ctl = snd_hda_codec_read(codec, pin_nid, 0, ATI_VERB_GET_HBR_CONTROL, 0);
|
||||
if (hbr_ctl & ATI_HBR_CAPABLE) {
|
||||
if (hbr_ctl >= 0 && (hbr_ctl & ATI_HBR_CAPABLE)) {
|
||||
if (hbr)
|
||||
hbr_ctl_new = hbr_ctl | ATI_HBR_ENABLE;
|
||||
else
|
||||
|
新增問題並參考
封鎖使用者