clk: divider: fix incorrect usage of container_of
divider_recalc_rate() is an helper function used by clock divider of
different types, so the structure containing the 'hw' pointer is not
always a 'struct clk_divider'
At the following line:
> div = _get_div(table, val, flags, divider->width);
in several cases, the value of 'divider->width' is garbage as the actual
structure behind this memory is not a 'struct clk_divider'
Fortunately, this width value is used by _get_val() only when
CLK_DIVIDER_MAX_AT_ZERO flag is set. This has never been the case so
far when the structure is not a 'struct clk_divider'. This is probably
why we did not notice this bug before
Fixes: afe76c8fd0
("clk: allow a clk divider with max divisor when zero")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Sylvain Lemieux <slemieux.tyco@gmail.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Šī revīzija ir iekļauta:

revīziju iesūtīja
Stephen Boyd

vecāks
4fbd8d194f
revīzija
12a26c298d
@@ -71,7 +71,7 @@ static unsigned long ccu_div_recalc_rate(struct clk_hw *hw,
|
||||
parent_rate);
|
||||
|
||||
val = divider_recalc_rate(hw, parent_rate, val, cd->div.table,
|
||||
cd->div.flags);
|
||||
cd->div.flags, cd->div.width);
|
||||
|
||||
if (cd->common.features & CCU_FEATURE_FIXED_POSTDIV)
|
||||
val /= cd->fixed_post_div;
|
||||
|
Atsaukties uz šo jaunā problēmā
Block a user