tcp: Fix a data-race around sysctl_tcp_early_retrans.
[ Upstream commit 52e65865deb6a36718a463030500f16530eaab74 ]
While reading sysctl_tcp_early_retrans, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.
Fixes: eed530b6c6
("tcp: early retransmit")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
ffc388f6f0
commit
11e8b013d1
@@ -2735,7 +2735,7 @@ bool tcp_schedule_loss_probe(struct sock *sk, bool advancing_rto)
|
|||||||
if (rcu_access_pointer(tp->fastopen_rsk))
|
if (rcu_access_pointer(tp->fastopen_rsk))
|
||||||
return false;
|
return false;
|
||||||
|
|
||||||
early_retrans = sock_net(sk)->ipv4.sysctl_tcp_early_retrans;
|
early_retrans = READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_early_retrans);
|
||||||
/* Schedule a loss probe in 2*RTT for SACK capable connections
|
/* Schedule a loss probe in 2*RTT for SACK capable connections
|
||||||
* not in loss recovery, that are either limited by cwnd or application.
|
* not in loss recovery, that are either limited by cwnd or application.
|
||||||
*/
|
*/
|
||||||
|
Reference in New Issue
Block a user