Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty-2.6
* git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty-2.6: (58 commits) tty: split the lock up a bit further tty: Move the leader test in disassociate tty: Push the bkl down a bit in the hangup code tty: Push the lock down further into the ldisc code tty: push the BKL down into the handlers a bit tty: moxa: split open lock tty: moxa: Kill the use of lock_kernel tty: moxa: Fix modem op locking tty: moxa: Kill off the throttle method tty: moxa: Locking clean up tty: moxa: rework the locking a bit tty: moxa: Use more tty_port ops tty: isicom: fix deadlock on shutdown tty: mxser: Use the new locking rules to fix setserial properly tty: mxser: use the tty_port_open method tty: isicom: sort out the board init logic tty: isicom: switch to the new tty_port_open helper tty: tty_port: Add a kref object to the tty port tty: istallion: tty port open/close methods tty: stallion: Convert to the tty_port_open/close methods ...
This commit is contained in:
@@ -501,12 +501,13 @@ static int opticon_resume(struct usb_interface *intf)
|
||||
struct usb_serial_port *port = serial->port[0];
|
||||
int result;
|
||||
|
||||
mutex_lock(&port->mutex);
|
||||
if (port->port.count)
|
||||
mutex_lock(&port->port.mutex);
|
||||
/* This is protected by the port mutex against close/open */
|
||||
if (test_bit(ASYNCB_INITIALIZED, &port->port.flags))
|
||||
result = usb_submit_urb(priv->bulk_read_urb, GFP_NOIO);
|
||||
else
|
||||
result = 0;
|
||||
mutex_unlock(&port->mutex);
|
||||
mutex_unlock(&port->port.mutex);
|
||||
return result;
|
||||
}
|
||||
|
||||
|
@@ -247,96 +247,66 @@ static int serial_install(struct tty_driver *driver, struct tty_struct *tty)
|
||||
return retval;
|
||||
}
|
||||
|
||||
static int serial_open(struct tty_struct *tty, struct file *filp)
|
||||
static int serial_activate(struct tty_port *tport, struct tty_struct *tty)
|
||||
{
|
||||
struct usb_serial_port *port = tty->driver_data;
|
||||
struct usb_serial_port *port =
|
||||
container_of(tport, struct usb_serial_port, port);
|
||||
struct usb_serial *serial = port->serial;
|
||||
int retval;
|
||||
|
||||
dbg("%s - port %d", __func__, port->number);
|
||||
|
||||
spin_lock_irq(&port->port.lock);
|
||||
if (!tty_hung_up_p(filp))
|
||||
++port->port.count;
|
||||
spin_unlock_irq(&port->port.lock);
|
||||
tty_port_tty_set(&port->port, tty);
|
||||
|
||||
/* Do the device-specific open only if the hardware isn't
|
||||
* already initialized.
|
||||
*/
|
||||
if (!test_bit(ASYNCB_INITIALIZED, &port->port.flags)) {
|
||||
if (mutex_lock_interruptible(&port->mutex))
|
||||
return -ERESTARTSYS;
|
||||
mutex_lock(&serial->disc_mutex);
|
||||
if (serial->disconnected)
|
||||
retval = -ENODEV;
|
||||
else
|
||||
retval = port->serial->type->open(tty, port);
|
||||
mutex_unlock(&serial->disc_mutex);
|
||||
mutex_unlock(&port->mutex);
|
||||
if (retval)
|
||||
return retval;
|
||||
set_bit(ASYNCB_INITIALIZED, &port->port.flags);
|
||||
}
|
||||
|
||||
/* Now do the correct tty layer semantics */
|
||||
retval = tty_port_block_til_ready(&port->port, tty, filp);
|
||||
mutex_lock(&serial->disc_mutex);
|
||||
if (serial->disconnected)
|
||||
retval = -ENODEV;
|
||||
else
|
||||
retval = port->serial->type->open(tty, port);
|
||||
mutex_unlock(&serial->disc_mutex);
|
||||
return retval;
|
||||
}
|
||||
|
||||
static int serial_open(struct tty_struct *tty, struct file *filp)
|
||||
{
|
||||
struct usb_serial_port *port = tty->driver_data;
|
||||
|
||||
dbg("%s - port %d", __func__, port->number);
|
||||
return tty_port_open(&port->port, tty, filp);
|
||||
}
|
||||
|
||||
/**
|
||||
* serial_down - shut down hardware
|
||||
* @port: port to shut down
|
||||
* @tport: tty port to shut down
|
||||
*
|
||||
* Shut down a USB serial port unless it is the console. We never
|
||||
* shut down the console hardware as it will always be in use.
|
||||
* shut down the console hardware as it will always be in use. Serialized
|
||||
* against activate by the tport mutex and kept to matching open/close pairs
|
||||
* of calls by the ASYNCB_INITIALIZED flag.
|
||||
*/
|
||||
static void serial_down(struct usb_serial_port *port)
|
||||
static void serial_down(struct tty_port *tport)
|
||||
{
|
||||
struct usb_serial_port *port =
|
||||
container_of(tport, struct usb_serial_port, port);
|
||||
struct usb_serial_driver *drv = port->serial->type;
|
||||
|
||||
/*
|
||||
* The console is magical. Do not hang up the console hardware
|
||||
* or there will be tears.
|
||||
*/
|
||||
if (port->console)
|
||||
return;
|
||||
|
||||
/* Don't call the close method if the hardware hasn't been
|
||||
* initialized.
|
||||
*/
|
||||
if (!test_and_clear_bit(ASYNCB_INITIALIZED, &port->port.flags))
|
||||
return;
|
||||
|
||||
mutex_lock(&port->mutex);
|
||||
if (drv->close)
|
||||
drv->close(port);
|
||||
mutex_unlock(&port->mutex);
|
||||
}
|
||||
|
||||
static void serial_hangup(struct tty_struct *tty)
|
||||
{
|
||||
struct usb_serial_port *port = tty->driver_data;
|
||||
|
||||
dbg("%s - port %d", __func__, port->number);
|
||||
|
||||
serial_down(port);
|
||||
tty_port_hangup(&port->port);
|
||||
}
|
||||
|
||||
static void serial_close(struct tty_struct *tty, struct file *filp)
|
||||
{
|
||||
struct usb_serial_port *port = tty->driver_data;
|
||||
|
||||
dbg("%s - port %d", __func__, port->number);
|
||||
|
||||
if (tty_hung_up_p(filp))
|
||||
return;
|
||||
if (tty_port_close_start(&port->port, tty, filp) == 0)
|
||||
return;
|
||||
serial_down(port);
|
||||
tty_port_close_end(&port->port, tty);
|
||||
tty_port_tty_set(&port->port, NULL);
|
||||
tty_port_close(&port->port, tty, filp);
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -725,6 +695,8 @@ static void serial_dtr_rts(struct tty_port *port, int on)
|
||||
static const struct tty_port_operations serial_port_ops = {
|
||||
.carrier_raised = serial_carrier_raised,
|
||||
.dtr_rts = serial_dtr_rts,
|
||||
.activate = serial_activate,
|
||||
.shutdown = serial_down,
|
||||
};
|
||||
|
||||
int usb_serial_probe(struct usb_interface *interface,
|
||||
@@ -923,7 +895,8 @@ int usb_serial_probe(struct usb_interface *interface,
|
||||
port->port.ops = &serial_port_ops;
|
||||
port->serial = serial;
|
||||
spin_lock_init(&port->lock);
|
||||
mutex_init(&port->mutex);
|
||||
/* Keep this for private driver use for the moment but
|
||||
should probably go away */
|
||||
INIT_WORK(&port->work, usb_serial_port_work);
|
||||
serial->port[i] = port;
|
||||
port->dev.parent = &interface->dev;
|
||||
|
Reference in New Issue
Block a user