xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pstore: Improve and update some comments and status output

Browse Source 
This improves and updates some comments:
 - dump handler comment out of sync from calling convention
 - fix kern-doc typo

and improves status output:
 - reminder that only kernel crash dumps are compressed
 - do not be silent about ECC infrastructure failures

Signed-off-by: Kees Cook <keescook@chromium.org>
This commit is contained in:
Kees Cook
2018-11-01 14:03:07 -07:00
parent c208f7d4b0
commit 0eed84ffb0
3 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
fs/pstore/platform.c
View File

@@ -304,7 +304,7 @@ static void allocate_buf_for_compression(void)
big_oops_buf_sz = size; big_oops_buf_sz = size;
big_oops_buf = buf; big_oops_buf = buf;
pr_info("Using compression: %s\n", zbackend->name); pr_info("Using crash dump compression: %s\n", zbackend->name);
} }
static void free_buf_for_compression(void) static void free_buf_for_compression(void)
@@ -354,9 +354,8 @@ void pstore_record_init(struct pstore_record *record,
} }
/* /*
* callback from kmsg_dump. (s2,l2) has the most recently * callback from kmsg_dump. Save as much as we can (up to kmsg_bytes) from the
* written bytes, older bytes are in (s1,l1). Save as much * end of the buffer.
* as we can from the end of the buffer.
*/ */
static void pstore_dump(struct kmsg_dumper *dumper, static void pstore_dump(struct kmsg_dumper *dumper,
enum kmsg_dump_reason reason) enum kmsg_dump_reason reason)

4
fs/pstore/ram_core.c
View File

@@ -503,8 +503,10 @@ static int persistent_ram_post_init(struct persistent_ram_zone *prz, u32 sig,
bool zap = !!(prz->flags & PRZ_FLAG_ZAP_OLD); bool zap = !!(prz->flags & PRZ_FLAG_ZAP_OLD);
ret = persistent_ram_init_ecc(prz, ecc_info); ret = persistent_ram_init_ecc(prz, ecc_info);
if (ret) if (ret) {
pr_warn("ECC failed %s\n", prz->label);
return ret; return ret;
}
sig ^= PERSISTENT_RAM_SIG; sig ^= PERSISTENT_RAM_SIG;

2
include/linux/pstore.h
View File

@@ -85,7 +85,7 @@ struct pstore_record {
/** /**
* struct pstore_info - backend pstore driver structure * struct pstore_info - backend pstore driver structure
* *
* @owner: module which is repsonsible for this backend driver * @owner: module which is responsible for this backend driver
* @name: name of the backend driver * @name: name of the backend driver
* *
* @buf_lock: spinlock to serialize access to @buf * @buf_lock: spinlock to serialize access to @buf