tpm: Fix handling of missing event log
The event log is an optional firmware feature, if the firmware does not support it then the securityfs files should not be created and no other notification given. - Uniformly return -ENODEV from the tpm_bios_log_setup cone if no event log is detected. - Check in ACPI if this node was discovered via ACPI. - Improve the check in OF to make sure there is a parent and to fail detection if the two log properties are not declared - Pass through all other error codes instead of filtering just some Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
This commit is contained in:

zatwierdzone przez
Jarkko Sakkinen

rodzic
005451d44a
commit
0cf577a03f
@@ -29,13 +29,16 @@ int tpm_read_log_of(struct tpm_chip *chip)
|
||||
struct tpm_bios_log *log;
|
||||
|
||||
log = &chip->log;
|
||||
if (chip->dev.parent->of_node)
|
||||
if (chip->dev.parent && chip->dev.parent->of_node)
|
||||
np = chip->dev.parent->of_node;
|
||||
else
|
||||
return -ENODEV;
|
||||
|
||||
sizep = of_get_property(np, "linux,sml-size", NULL);
|
||||
if (sizep == NULL)
|
||||
basep = of_get_property(np, "linux,sml-base", NULL);
|
||||
if (sizep == NULL && basep == NULL)
|
||||
return -ENODEV;
|
||||
if (sizep == NULL || basep == NULL)
|
||||
return -EIO;
|
||||
|
||||
if (*sizep == 0) {
|
||||
@@ -43,10 +46,6 @@ int tpm_read_log_of(struct tpm_chip *chip)
|
||||
return -EIO;
|
||||
}
|
||||
|
||||
basep = of_get_property(np, "linux,sml-base", NULL);
|
||||
if (basep == NULL)
|
||||
return -EIO;
|
||||
|
||||
log->bios_event_log = kmalloc(*sizep, GFP_KERNEL);
|
||||
if (!log->bios_event_log)
|
||||
return -ENOMEM;
|
||||
|
Reference in New Issue
Block a user