CAPI: Rework locking of controller data structures
This patch applies the mutex so far only protecting the controller list to (almost) all accesses of controller data structures. It also reworks waiting on state changes in old_capi_manufacturer so that it no longer poll and holds a module reference to the controller owner while waiting (the latter was partly done already). Modification and checking of the blocked state remains racy by design, the caller is responsible for dealing with this. Signed-off-by: Jan Kiszka <jan.kiszka@web.de> Signed-off-by: David S. Miller <davem@davemloft.net>
Šī revīzija ir iekļauta:

revīziju iesūtīja
David S. Miller

vecāks
ef69bb2ec6
revīzija
0ca3a017a7
@@ -35,7 +35,10 @@ static char *state2str(unsigned short state)
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
static void *controller_start(struct seq_file *seq, loff_t *pos)
|
||||
__acquires(capi_controller_lock)
|
||||
{
|
||||
mutex_lock(&capi_controller_lock);
|
||||
|
||||
if (*pos < CAPI_MAXCONTR)
|
||||
return &capi_controller[*pos];
|
||||
|
||||
@@ -52,7 +55,9 @@ static void *controller_next(struct seq_file *seq, void *v, loff_t *pos)
|
||||
}
|
||||
|
||||
static void controller_stop(struct seq_file *seq, void *v)
|
||||
__releases(capi_controller_lock)
|
||||
{
|
||||
mutex_unlock(&capi_controller_lock);
|
||||
}
|
||||
|
||||
static int controller_show(struct seq_file *seq, void *v)
|
||||
|
Atsaukties uz šo jaunā problēmā
Block a user