net: hns3: Fix to support autoneg only for port attached with phy
This patch adds a check to support autoneg(ethtool -A) only when PHY
is attached with the port.
Fixes: e2cb1dec97
("net: hns3: Add HNS3 VF HCL(Hardware Compatibility
Layer) Support")
Signed-off-by: Fuyun Liang <liangfuyun1@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
c5ef83cbb1
commit
0c963e8c20
@@ -5169,12 +5169,6 @@ static int hclge_set_pauseparam(struct hnae3_handle *handle, u32 auto_neg,
|
|||||||
struct phy_device *phydev = hdev->hw.mac.phydev;
|
struct phy_device *phydev = hdev->hw.mac.phydev;
|
||||||
u32 fc_autoneg;
|
u32 fc_autoneg;
|
||||||
|
|
||||||
/* Only support flow control negotiation for netdev with
|
|
||||||
* phy attached for now.
|
|
||||||
*/
|
|
||||||
if (!phydev)
|
|
||||||
return -EOPNOTSUPP;
|
|
||||||
|
|
||||||
fc_autoneg = hclge_get_autoneg(handle);
|
fc_autoneg = hclge_get_autoneg(handle);
|
||||||
if (auto_neg != fc_autoneg) {
|
if (auto_neg != fc_autoneg) {
|
||||||
dev_info(&hdev->pdev->dev,
|
dev_info(&hdev->pdev->dev,
|
||||||
@@ -5193,6 +5187,12 @@ static int hclge_set_pauseparam(struct hnae3_handle *handle, u32 auto_neg,
|
|||||||
if (!fc_autoneg)
|
if (!fc_autoneg)
|
||||||
return hclge_cfg_pauseparam(hdev, rx_en, tx_en);
|
return hclge_cfg_pauseparam(hdev, rx_en, tx_en);
|
||||||
|
|
||||||
|
/* Only support flow control negotiation for netdev with
|
||||||
|
* phy attached for now.
|
||||||
|
*/
|
||||||
|
if (!phydev)
|
||||||
|
return -EOPNOTSUPP;
|
||||||
|
|
||||||
return phy_start_aneg(phydev);
|
return phy_start_aneg(phydev);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user