mac80211: convert to %pM away from print_mac
Also remove a few stray DECLARE_MAC_BUF that were no longer used at all. Signed-off-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
dd45c9cf68
commit
0c68ae2605
@@ -653,13 +653,12 @@ ieee80211_rx_h_decrypt(struct ieee80211_rx_data *rx)
|
||||
static void ap_sta_ps_start(struct sta_info *sta)
|
||||
{
|
||||
struct ieee80211_sub_if_data *sdata = sta->sdata;
|
||||
DECLARE_MAC_BUF(mac);
|
||||
|
||||
atomic_inc(&sdata->bss->num_sta_ps);
|
||||
set_and_clear_sta_flags(sta, WLAN_STA_PS, WLAN_STA_PSPOLL);
|
||||
#ifdef CONFIG_MAC80211_VERBOSE_PS_DEBUG
|
||||
printk(KERN_DEBUG "%s: STA %s aid %d enters power save mode\n",
|
||||
sdata->dev->name, print_mac(mac, sta->sta.addr), sta->sta.aid);
|
||||
printk(KERN_DEBUG "%s: STA %pM aid %d enters power save mode\n",
|
||||
sdata->dev->name, sta->sta.addr, sta->sta.aid);
|
||||
#endif /* CONFIG_MAC80211_VERBOSE_PS_DEBUG */
|
||||
}
|
||||
|
||||
@@ -670,7 +669,6 @@ static int ap_sta_ps_end(struct sta_info *sta)
|
||||
struct sk_buff *skb;
|
||||
int sent = 0;
|
||||
struct ieee80211_tx_info *info;
|
||||
DECLARE_MAC_BUF(mac);
|
||||
|
||||
atomic_dec(&sdata->bss->num_sta_ps);
|
||||
|
||||
@@ -680,8 +678,8 @@ static int ap_sta_ps_end(struct sta_info *sta)
|
||||
sta_info_clear_tim_bit(sta);
|
||||
|
||||
#ifdef CONFIG_MAC80211_VERBOSE_PS_DEBUG
|
||||
printk(KERN_DEBUG "%s: STA %s aid %d exits power save mode\n",
|
||||
sdata->dev->name, print_mac(mac, sta->sta.addr), sta->sta.aid);
|
||||
printk(KERN_DEBUG "%s: STA %pM aid %d exits power save mode\n",
|
||||
sdata->dev->name, sta->sta.addr, sta->sta.aid);
|
||||
#endif /* CONFIG_MAC80211_VERBOSE_PS_DEBUG */
|
||||
|
||||
/* Send all buffered frames to the station */
|
||||
@@ -696,9 +694,9 @@ static int ap_sta_ps_end(struct sta_info *sta)
|
||||
local->total_ps_buffered--;
|
||||
sent++;
|
||||
#ifdef CONFIG_MAC80211_VERBOSE_PS_DEBUG
|
||||
printk(KERN_DEBUG "%s: STA %s aid %d send PS frame "
|
||||
printk(KERN_DEBUG "%s: STA %pM aid %d send PS frame "
|
||||
"since STA not sleeping anymore\n", sdata->dev->name,
|
||||
print_mac(mac, sta->sta.addr), sta->sta.aid);
|
||||
sta->sta.addr, sta->sta.aid);
|
||||
#endif /* CONFIG_MAC80211_VERBOSE_PS_DEBUG */
|
||||
info->flags |= IEEE80211_TX_CTL_REQUEUE;
|
||||
dev_queue_xmit(skb);
|
||||
@@ -789,15 +787,12 @@ ieee80211_reassemble_add(struct ieee80211_sub_if_data *sdata,
|
||||
#ifdef CONFIG_MAC80211_VERBOSE_DEBUG
|
||||
struct ieee80211_hdr *hdr =
|
||||
(struct ieee80211_hdr *) entry->skb_list.next->data;
|
||||
DECLARE_MAC_BUF(mac);
|
||||
DECLARE_MAC_BUF(mac2);
|
||||
printk(KERN_DEBUG "%s: RX reassembly removed oldest "
|
||||
"fragment entry (idx=%d age=%lu seq=%d last_frag=%d "
|
||||
"addr1=%s addr2=%s\n",
|
||||
"addr1=%pM addr2=%pM\n",
|
||||
sdata->dev->name, idx,
|
||||
jiffies - entry->first_frag_time, entry->seq,
|
||||
entry->last_frag, print_mac(mac, hdr->addr1),
|
||||
print_mac(mac2, hdr->addr2));
|
||||
entry->last_frag, hdr->addr1, hdr->addr2);
|
||||
#endif
|
||||
__skb_queue_purge(&entry->skb_list);
|
||||
}
|
||||
@@ -866,7 +861,6 @@ ieee80211_rx_h_defragment(struct ieee80211_rx_data *rx)
|
||||
unsigned int frag, seq;
|
||||
struct ieee80211_fragment_entry *entry;
|
||||
struct sk_buff *skb;
|
||||
DECLARE_MAC_BUF(mac);
|
||||
|
||||
hdr = (struct ieee80211_hdr *)rx->skb->data;
|
||||
fc = hdr->frame_control;
|
||||
@@ -970,7 +964,6 @@ ieee80211_rx_h_ps_poll(struct ieee80211_rx_data *rx)
|
||||
struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(rx->dev);
|
||||
struct sk_buff *skb;
|
||||
int no_pending_pkts;
|
||||
DECLARE_MAC_BUF(mac);
|
||||
__le16 fc = ((struct ieee80211_hdr *)rx->skb->data)->frame_control;
|
||||
|
||||
if (likely(!rx->sta || !ieee80211_is_pspoll(fc) ||
|
||||
@@ -1001,8 +994,8 @@ ieee80211_rx_h_ps_poll(struct ieee80211_rx_data *rx)
|
||||
set_sta_flags(rx->sta, WLAN_STA_PSPOLL);
|
||||
|
||||
#ifdef CONFIG_MAC80211_VERBOSE_PS_DEBUG
|
||||
printk(KERN_DEBUG "STA %s aid %d: PS Poll (entries after %d)\n",
|
||||
print_mac(mac, rx->sta->sta.addr), rx->sta->sta.aid,
|
||||
printk(KERN_DEBUG "STA %pM aid %d: PS Poll (entries after %d)\n",
|
||||
rx->sta->sta.addr, rx->sta->sta.aid,
|
||||
skb_queue_len(&rx->sta->ps_tx_buf));
|
||||
#endif /* CONFIG_MAC80211_VERBOSE_PS_DEBUG */
|
||||
|
||||
@@ -1025,9 +1018,9 @@ ieee80211_rx_h_ps_poll(struct ieee80211_rx_data *rx)
|
||||
* Should we send it a null-func frame indicating we
|
||||
* have nothing buffered for it?
|
||||
*/
|
||||
printk(KERN_DEBUG "%s: STA %s sent PS Poll even "
|
||||
printk(KERN_DEBUG "%s: STA %pM sent PS Poll even "
|
||||
"though there are no buffered frames for it\n",
|
||||
rx->dev->name, print_mac(mac, rx->sta->sta.addr));
|
||||
rx->dev->name, rx->sta->sta.addr);
|
||||
#endif /* CONFIG_MAC80211_VERBOSE_PS_DEBUG */
|
||||
}
|
||||
|
||||
@@ -1097,10 +1090,6 @@ ieee80211_data_to_8023(struct ieee80211_rx_data *rx)
|
||||
u8 src[ETH_ALEN] __aligned(2);
|
||||
struct sk_buff *skb = rx->skb;
|
||||
struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
|
||||
DECLARE_MAC_BUF(mac);
|
||||
DECLARE_MAC_BUF(mac2);
|
||||
DECLARE_MAC_BUF(mac3);
|
||||
DECLARE_MAC_BUF(mac4);
|
||||
|
||||
if (unlikely(!ieee80211_is_data_present(hdr->frame_control)))
|
||||
return -1;
|
||||
@@ -1279,7 +1268,6 @@ ieee80211_rx_h_amsdu(struct ieee80211_rx_data *rx)
|
||||
int remaining, err;
|
||||
u8 dst[ETH_ALEN];
|
||||
u8 src[ETH_ALEN];
|
||||
DECLARE_MAC_BUF(mac);
|
||||
|
||||
if (unlikely(!ieee80211_is_data(fc)))
|
||||
return RX_CONTINUE;
|
||||
@@ -1632,8 +1620,6 @@ static void ieee80211_rx_michael_mic_report(struct net_device *dev,
|
||||
{
|
||||
int keyidx;
|
||||
unsigned int hdrlen;
|
||||
DECLARE_MAC_BUF(mac);
|
||||
DECLARE_MAC_BUF(mac2);
|
||||
|
||||
hdrlen = ieee80211_hdrlen(hdr->frame_control);
|
||||
if (rx->skb->len >= hdrlen + 4)
|
||||
|
Reference in New Issue
Block a user