powerpc/eeh: Remove reference to PCI device
We will rely on pcibios_release_device() to remove the EEH cache and unbind EEH device for the specific PCI device. So we shouldn't hold the reference to the PCI device from EEH cache and EEH device. Otherwise, pcibios_release_device() won't be called as we expected. The patch removes the reference to the PCI device in EEH core. Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
This commit is contained in:

committed by
Benjamin Herrenschmidt

parent
ee1dd1e3dc
commit
0ba178888b
@@ -499,8 +499,6 @@ unsigned long eeh_check_failure(const volatile void __iomem *token, unsigned lon
|
||||
}
|
||||
|
||||
eeh_dev_check_failure(edev);
|
||||
|
||||
pci_dev_put(eeh_dev_to_pci_dev(edev));
|
||||
return val;
|
||||
}
|
||||
|
||||
@@ -904,7 +902,6 @@ static void eeh_add_device_late(struct pci_dev *dev)
|
||||
}
|
||||
WARN_ON(edev->pdev);
|
||||
|
||||
pci_dev_get(dev);
|
||||
edev->pdev = dev;
|
||||
dev->dev.archdata.edev = edev;
|
||||
|
||||
@@ -992,7 +989,6 @@ static void eeh_remove_device(struct pci_dev *dev, int purge_pe)
|
||||
}
|
||||
edev->pdev = NULL;
|
||||
dev->dev.archdata.edev = NULL;
|
||||
pci_dev_put(dev);
|
||||
|
||||
eeh_rmv_from_parent_pe(edev, purge_pe);
|
||||
eeh_addr_cache_rmv_dev(dev);
|
||||
|
Reference in New Issue
Block a user