xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

power: reset: ltc2952: prefer devm_kzalloc over kzalloc

Browse Source 
Make use of the fact that the allocated resources can be automatically
deallocated. This reduces cleanup code and chance of leaks.

Signed-off-by: Frans Klaver <frans.klaver@xsens.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
This commit is contained in:
Frans Klaver
2015-01-14 09:15:34 +01:00
committed by Sebastian Reichel
parent 0160817d10
commit 0a5c6a2276
1 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/power/reset/ltc2952-poweroff.c
View File

@@ -292,7 +292,8 @@ static int ltc2952_poweroff_probe(struct platform_device *pdev)
return -EBUSY; return -EBUSY;
} }
ltc2952_data = kzalloc(sizeof(*ltc2952_data), GFP_KERNEL); ltc2952_data = devm_kzalloc(&pdev->dev, sizeof(*ltc2952_data),
GFP_KERNEL);
if (!ltc2952_data) if (!ltc2952_data)
return -ENOMEM; return -ENOMEM;
@@ -300,17 +301,13 @@ static int ltc2952_poweroff_probe(struct platform_device *pdev)
ret = ltc2952_poweroff_init(pdev); ret = ltc2952_poweroff_init(pdev);
if (ret) if (ret)
goto err; return ret;
pm_power_off = &ltc2952_poweroff_kill; pm_power_off = &ltc2952_poweroff_kill;
dev_info(&pdev->dev, "probe successful\n"); dev_info(&pdev->dev, "probe successful\n");
return 0; return 0;
err:
kfree(ltc2952_data);
return ret;
} }
static int ltc2952_poweroff_remove(struct platform_device *pdev) static int ltc2952_poweroff_remove(struct platform_device *pdev)
@@ -324,8 +321,6 @@ static int ltc2952_poweroff_remove(struct platform_device *pdev)
for (i = 0; i < ARRAY_SIZE(ltc2952_data->gpio); i++) for (i = 0; i < ARRAY_SIZE(ltc2952_data->gpio); i++)
gpiod_put(ltc2952_data->gpio[i]); gpiod_put(ltc2952_data->gpio[i]);
kfree(ltc2952_data);
} }
return 0; return 0;