IB/mlx5: Move to fully dynamic UAR mode once user space supports it
Move to fully dynamic UAR mode once user space supports it. In this case we prevent any legacy mode of UARs on the allocated context and prevent redundant allocation of the static ones. Link: https://lore.kernel.org/r/20200324060143.1569116-6-leon@kernel.org Signed-off-by: Yishai Hadas <yishaih@mellanox.com> Reviewed-by: Michael Guralnik <michaelgur@mellanox.com> Signed-off-by: Leon Romanovsky <leonro@mellanox.com> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
This commit is contained in:

committed by
Jason Gunthorpe

parent
2152862298
commit
0a2fd01c28
@@ -1786,6 +1786,7 @@ static int mlx5_ib_alloc_ucontext(struct ib_ucontext *uctx,
|
||||
max_cqe_version);
|
||||
u32 dump_fill_mkey;
|
||||
bool lib_uar_4k;
|
||||
bool lib_uar_dyn;
|
||||
|
||||
if (!dev->ib_active)
|
||||
return -EAGAIN;
|
||||
@@ -1844,8 +1845,14 @@ static int mlx5_ib_alloc_ucontext(struct ib_ucontext *uctx,
|
||||
}
|
||||
|
||||
lib_uar_4k = req.lib_caps & MLX5_LIB_CAP_4K_UAR;
|
||||
lib_uar_dyn = req.lib_caps & MLX5_LIB_CAP_DYN_UAR;
|
||||
bfregi = &context->bfregi;
|
||||
|
||||
if (lib_uar_dyn) {
|
||||
bfregi->lib_uar_dyn = lib_uar_dyn;
|
||||
goto uar_done;
|
||||
}
|
||||
|
||||
/* updates req->total_num_bfregs */
|
||||
err = calc_total_bfregs(dev, lib_uar_4k, &req, bfregi);
|
||||
if (err)
|
||||
@@ -1872,6 +1879,7 @@ static int mlx5_ib_alloc_ucontext(struct ib_ucontext *uctx,
|
||||
if (err)
|
||||
goto out_sys_pages;
|
||||
|
||||
uar_done:
|
||||
if (req.flags & MLX5_IB_ALLOC_UCTX_DEVX) {
|
||||
err = mlx5_ib_devx_create(dev, true);
|
||||
if (err < 0)
|
||||
@@ -1893,7 +1901,7 @@ static int mlx5_ib_alloc_ucontext(struct ib_ucontext *uctx,
|
||||
INIT_LIST_HEAD(&context->db_page_list);
|
||||
mutex_init(&context->db_page_mutex);
|
||||
|
||||
resp.tot_bfregs = req.total_num_bfregs;
|
||||
resp.tot_bfregs = lib_uar_dyn ? 0 : req.total_num_bfregs;
|
||||
resp.num_ports = dev->num_ports;
|
||||
|
||||
if (offsetofend(typeof(resp), cqe_version) <= udata->outlen)
|
||||
@@ -2141,6 +2149,9 @@ static int uar_mmap(struct mlx5_ib_dev *dev, enum mlx5_ib_mmap_cmd cmd,
|
||||
int max_valid_idx = dyn_uar ? bfregi->num_sys_pages :
|
||||
bfregi->num_static_sys_pages;
|
||||
|
||||
if (bfregi->lib_uar_dyn)
|
||||
return -EINVAL;
|
||||
|
||||
if (vma->vm_end - vma->vm_start != PAGE_SIZE)
|
||||
return -EINVAL;
|
||||
|
||||
|
Reference in New Issue
Block a user