xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fsl_pq_mdio: Fix mdiobus allocation handling

Browse Source 
The driver could return success code even if mdiobus_alloc() failed.
This patch fixes the issue.

Signed-off-by: Anton Vorontsov <avorontsov@mvista.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Anton Vorontsov
2010-05-14 04:27:30 +00:00
committed by David S. Miller
parent a2f7922713
commit 08d18f3b62
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/fsl_pq_mdio.c
View File

@@ -277,15 +277,17 @@ static int fsl_pq_mdio_probe(struct of_device *ofdev,
int tbiaddr = -1; int tbiaddr = -1;
const u32 *addrp; const u32 *addrp;
u64 addr = 0, size = 0; u64 addr = 0, size = 0;
int err = 0; int err;
priv = kzalloc(sizeof(*priv), GFP_KERNEL); priv = kzalloc(sizeof(*priv), GFP_KERNEL);
if (!priv) if (!priv)
return -ENOMEM; return -ENOMEM;
new_bus = mdiobus_alloc(); new_bus = mdiobus_alloc();
if (NULL == new_bus) if (!new_bus) {
err = -ENOMEM;
goto err_free_priv; goto err_free_priv;
}
new_bus->name = "Freescale PowerQUICC MII Bus", new_bus->name = "Freescale PowerQUICC MII Bus",
new_bus->read = &fsl_pq_mdio_read, new_bus->read = &fsl_pq_mdio_read,