selftests: Fix raw socket bind tests with VRF
[ Upstream commit 0f108ae4452025fef529671998f6c7f1c4526790 ]
Commit referenced below added negative socket bind tests for VRF. The
socket binds should fail since the address to bind to is in a VRF yet
the socket is not bound to the VRF or a device within it. Update the
expected return code to check for 1 (bind failure) so the test passes
when the bind fails as expected. Add a 'show_hint' comment to explain
why the bind is expected to fail.
Fixes: 75b2b2b3db
("selftests: Add ipv4 address bind tests to fcnal-test")
Reported-by: Li Zhijian <lizhijian@fujitsu.com>
Signed-off-by: David Ahern <dsahern@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
5ba4dfb8b8
commit
08896ecfff
@@ -1747,8 +1747,9 @@ ipv4_addr_bind_vrf()
|
|||||||
for a in ${NSA_IP} ${VRF_IP}
|
for a in ${NSA_IP} ${VRF_IP}
|
||||||
do
|
do
|
||||||
log_start
|
log_start
|
||||||
|
show_hint "Socket not bound to VRF, but address is in VRF"
|
||||||
run_cmd nettest -s -R -P icmp -l ${a} -b
|
run_cmd nettest -s -R -P icmp -l ${a} -b
|
||||||
log_test_addr ${a} $? 0 "Raw socket bind to local address"
|
log_test_addr ${a} $? 1 "Raw socket bind to local address"
|
||||||
|
|
||||||
log_start
|
log_start
|
||||||
run_cmd nettest -s -R -P icmp -l ${a} -d ${NSA_DEV} -b
|
run_cmd nettest -s -R -P icmp -l ${a} -d ${NSA_DEV} -b
|
||||||
|
Reference in New Issue
Block a user